You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/29 04:30:53 UTC
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #15466: [Bug](filter) fix not in(null) return true
BiteTheDDDDt opened a new pull request, #15466:
URL: https://github.com/apache/doris/pull/15466
# Proposed changes
`not in(any, null)` == `(x!=any and x!=null)`
`(x!=null)` = `null` = `false`, so not in(any, null) return always false
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #15466:
URL: https://github.com/apache/doris/pull/15466#issuecomment-1367778719
>
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15466:
URL: https://github.com/apache/doris/pull/15466#issuecomment-1369456843
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15466:
URL: https://github.com/apache/doris/pull/15466#issuecomment-1369456867
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
HappenLee commented on PR #15466:
URL: https://github.com/apache/doris/pull/15466#issuecomment-1367111374
Please add regresstest and consider `delete from table a where c not in (10, null)?`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15466:
URL: https://github.com/apache/doris/pull/15466#issuecomment-1369388474
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15466:
URL: https://github.com/apache/doris/pull/15466#issuecomment-1369369927
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15466:
URL: https://github.com/apache/doris/pull/15466#issuecomment-1367114747
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.14 seconds
load time: 633 seconds
storage size: 17123809687 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221229070701_clickbench_pr_70748.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #15466:
URL: https://github.com/apache/doris/pull/15466#discussion_r1059645378
##########
be/src/vec/exec/scan/vscan_node.cpp:
##########
@@ -771,6 +771,13 @@ Status VScanNode::_normalize_not_in_and_not_eq_predicate(VExpr* expr, VExprConte
->get_function_state(FunctionContext::FRAGMENT_LOCAL));
HybridSetBase::IteratorBase* iter = state->hybrid_set->begin();
auto fn_name = std::string("");
+
+ // not in(any, null) == (x!=any and x!=null)
+ // (x!=null)=null=false, so not in(any, null) return always false
Review Comment:
`in (any, null)` does not always return false, in fact, it returns `null`.
an counter example:
`k not in (null)` returns null, so `not ( k not in (null)` returns null.
`select * from t where k not in (null) ` returns empty result set.
`select * from t where not (k not in (null)) ` returns empty result set too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15466:
URL: https://github.com/apache/doris/pull/15466#issuecomment-1368825731
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15466:
URL: https://github.com/apache/doris/pull/15466#issuecomment-1367126439
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15466:
URL: https://github.com/apache/doris/pull/15466#issuecomment-1368734480
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15466:
URL: https://github.com/apache/doris/pull/15466#issuecomment-1367066899
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt merged PR #15466:
URL: https://github.com/apache/doris/pull/15466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15466:
URL: https://github.com/apache/doris/pull/15466#issuecomment-1369362310
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15466: [Bug](filter) fix not in(null) return true
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15466:
URL: https://github.com/apache/doris/pull/15466#issuecomment-1368242629
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org