You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/22 00:13:27 UTC

[GitHub] [beam] apilloud commented on a change in pull request #15712: [BEAM-12976] Add Java interfaces for projection pushdown.

apilloud commented on a change in pull request #15712:
URL: https://github.com/apache/beam/pull/15712#discussion_r734126503



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java
##########
@@ -702,7 +702,7 @@ public static DoFnSchemaInformation getDoFnSchemaInformation(
   public static class SingleOutput<InputT, OutputT>
       extends PTransform<PCollection<? extends InputT>, PCollection<OutputT>> {
 
-    private static final String MAIN_OUTPUT_TAG = "output";
+    public static final String MAIN_OUTPUT_TAG = "output";

Review comment:
       There were explicit comments on the original PR adding this suggesting it not be `public`.  Seems like this might not be the right thing to do? https://github.com/apache/beam/pull/4356#issuecomment-356106535
   
   cc: @kennknowles @lukecwik 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org