You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/12/29 17:09:44 UTC

[GitHub] [rocketmq] horizonzy opened a new pull request #2532: [ISSUE #2529] Supply a way to init executorService.

horizonzy opened a new pull request #2532:
URL: https://github.com/apache/rocketmq/pull/2532


   ## What is the purpose of the change
   
   For-#2529
   Supply a way to init executorService.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2532: [ISSUE #2529] Supply a way to init executorService.

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #2532:
URL: https://github.com/apache/rocketmq/pull/2532#issuecomment-752326701


   
   [![Coverage Status](https://coveralls.io/builds/35998591/badge)](https://coveralls.io/builds/35998591)
   
   Coverage decreased (-0.2%) to 51.75% when pulling **922b36e031f5e08cf7d33f2dce60eefc651188b4 on horizonzy:fix-2529** into **0239421fa59b67c423cf9fcabf5cd6edda0c2076 on apache:develop**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] horizonzy closed pull request #2532: [ISSUE #2529] Supply a way to init executorService.

Posted by GitBox <gi...@apache.org>.

horizonzy closed pull request #2532:
URL: https://github.com/apache/rocketmq/pull/2532


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-io commented on pull request #2532: [ISSUE #2529] Supply a way to init executorService.

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #2532:
URL: https://github.com/apache/rocketmq/pull/2532#issuecomment-752326728


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2532?src=pr&el=h1) Report
   > Merging [#2532](https://codecov.io/gh/apache/rocketmq/pull/2532?src=pr&el=desc) (922b36e) into [develop](https://codecov.io/gh/apache/rocketmq/commit/0239421fa59b67c423cf9fcabf5cd6edda0c2076?el=desc) (0239421) will **decrease** coverage by `0.09%`.
   > The diff coverage is `93.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2532/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv)](https://codecov.io/gh/apache/rocketmq/pull/2532?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #2532      +/-   ##
   =============================================
   - Coverage      45.97%   45.87%   -0.10%     
   + Complexity      4318     4313       -5     
   =============================================
     Files            547      548       +1     
     Lines          36236    36233       -3     
     Branches        4808     4808              
   =============================================
   - Hits           16658    16623      -35     
   - Misses         17491    17520      +29     
   - Partials        2087     2090       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2532?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ketmq/broker/latency/BrokerThreadPoolExecutor.java](https://codecov.io/gh/apache/rocketmq/pull/2532/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbGF0ZW5jeS9Ccm9rZXJUaHJlYWRQb29sRXhlY3V0b3IuamF2YQ==) | `22.22% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | [...rocketmq/broker/latency/BrokerExecutorFactory.java](https://codecov.io/gh/apache/rocketmq/pull/2532/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbGF0ZW5jeS9Ccm9rZXJFeGVjdXRvckZhY3RvcnkuamF2YQ==) | `75.00% <75.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...a/org/apache/rocketmq/broker/BrokerController.java](https://codecov.io/gh/apache/rocketmq/pull/2532/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | `44.20% <100.00%> (-0.70%)` | `38.00 <0.00> (ø)` | |
   | [...org/apache/rocketmq/broker/out/BrokerOuterAPI.java](https://codecov.io/gh/apache/rocketmq/pull/2532/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvb3V0L0Jyb2tlck91dGVyQVBJLmphdmE=) | `46.47% <100.00%> (ø)` | `12.00 <0.00> (ø)` | |
   | [...tmq/logappender/log4j2/RocketmqLog4j2Appender.java](https://codecov.io/gh/apache/rocketmq/pull/2532/diff?src=pr&el=tree#diff-bG9nYXBwZW5kZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2xvZ2FwcGVuZGVyL2xvZzRqMi9Sb2NrZXRtcUxvZzRqMkFwcGVuZGVyLmphdmE=) | `35.00% <0.00%> (-10.00%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...ain/java/org/apache/rocketmq/test/util/MQWait.java](https://codecov.io/gh/apache/rocketmq/pull/2532/diff?src=pr&el=tree#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RV2FpdC5qYXZh) | `43.24% <0.00%> (-5.41%)` | `3.00% <0.00%> (ø%)` | |
   | [...apache/rocketmq/remoting/netty/ResponseFuture.java](https://codecov.io/gh/apache/rocketmq/pull/2532/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L1Jlc3BvbnNlRnV0dXJlLmphdmE=) | `85.00% <0.00%> (-5.00%)` | `16.00% <0.00%> (-2.00%)` | |
   | [...ketmq/common/protocol/body/ConsumerConnection.java](https://codecov.io/gh/apache/rocketmq/pull/2532/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9Db25zdW1lckNvbm5lY3Rpb24uamF2YQ==) | `95.83% <0.00%> (-4.17%)` | `13.00% <0.00%> (-1.00%)` | |
   | [...rocketmq/remoting/netty/NettyRemotingAbstract.java](https://codecov.io/gh/apache/rocketmq/pull/2532/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdBYnN0cmFjdC5qYXZh) | `46.86% <0.00%> (-4.06%)` | `20.00% <0.00%> (-2.00%)` | |
   | [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2532/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `41.79% <0.00%> (-1.50%)` | `16.00% <0.00%> (-1.00%)` | |
   | ... and [9 more](https://codecov.io/gh/apache/rocketmq/pull/2532/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2532?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2532?src=pr&el=footer). Last update [0239421...922b36e](https://codecov.io/gh/apache/rocketmq/pull/2532?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org