[GitHub] [geode-native] gaussianrecurrence commented on a change in pull request #776: GEODE-9078: Remove ACE mutexes

[GitBox <gi...@apache.org>]

gaussianrecurrence commented on a change in pull request #776:
URL: https://github.com/apache/geode-native/pull/776#discussion_r623778380



##########
File path: cppcache/src/AdminRegion.hpp
##########
@@ -48,7 +48,7 @@ class AdminRegion : public std::enable_shared_from_this<AdminRegion> {
   ThinClientBaseDM* m_distMngr;
   std::string m_fullPath;
   TcrConnectionManager* m_connectionMgr;
-  ACE_RW_Thread_Mutex m_rwLock;
+  boost::shared_mutex mutex_;

Review comment:
       I am trying to keep changes as minimal as possible. I have to confess every time I see something wrong, like this my OCD triggers and I am tempted to change it, but as I said I am trying to hold back hehe. However if you consider this is not a big change, I will update all the member variable names to match the current standard.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org