You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/09/16 12:00:08 UTC

[GitHub] [calcite] jinxing64 commented on a change in pull request #1451: [CALCITE-3334] Refinement for Substitution-Based MV Matching

jinxing64 commented on a change in pull request #1451: [CALCITE-3334] Refinement for Substitution-Based MV Matching
URL: https://github.com/apache/calcite/pull/1451#discussion_r324634227
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/RelOptMaterializations.java
 ##########
 @@ -64,6 +73,9 @@
         getApplicableMaterializations(rel, materializations);
     final List<Pair<RelNode, List<RelOptMaterialization>>> applied =
         new ArrayList<>();
+    if (SubstitutionVisitor.disabled) {
 
 Review comment:
   This is added for testing and differentiate MV optimization by `SubstitutionVisitor` and `AbstractMaterializedViewRule`. I'm not sure if I should add a config of `CalciteConnectionProperty`.
   Please share comments if there's suggestion

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services