You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/06 09:25:55 UTC
[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9969: [enhance] improve dict in-predicate evaluate
HappenLee commented on code in PR #9969:
URL: https://github.com/apache/incubator-doris/pull/9969#discussion_r889975221
##########
be/src/olap/in_list_predicate.cpp:
##########
@@ -132,13 +132,14 @@ IN_LIST_PRED_COLUMN_BLOCK_EVALUATE(NotInListPredicate, ==)
auto* nested_col_ptr = vectorized::check_and_get_column< \
vectorized::ColumnDictionary<vectorized::Int32>>(nested_col); \
auto& data_array = nested_col_ptr->get_data(); \
- auto dict_codes = nested_col_ptr->find_codes(_values); \
+ std::vector<bool> selected; \
+ size_t dict_word_num = 0; \
+ nested_col_ptr->find_codes(_values, selected, dict_word_num); \
for (uint16_t i = 0; i < *size; i++) { \
uint16_t idx = sel[i]; \
sel[new_size] = idx; \
const auto& cell_value = data_array[idx]; \
- bool ret = !null_bitmap[idx] && \
- (dict_codes.find(cell_value) OP dict_codes.end()); \
+ bool ret = !null_bitmap[idx] && (selected[cell_value] OP false); \
Review Comment:
code format of `\`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org