You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2022/12/12 14:59:36 UTC
svn commit: r1905932 - in /poi/trunk/poi/src: main/java/org/apache/poi/util/CodepointsUtil.java test/java/org/apache/poi/util/TestCodepointsUtil.java
Author: fanningpj
Date: Mon Dec 12 14:59:35 2022
New Revision: 1905932
URL: http://svn.apache.org/viewvc?rev=1905932&view=rev
Log:
[github-405] more performant codepoint util code. Thanks to StanBertrand. This closes #405
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/util/CodepointsUtil.java
poi/trunk/poi/src/test/java/org/apache/poi/util/TestCodepointsUtil.java
Modified: poi/trunk/poi/src/main/java/org/apache/poi/util/CodepointsUtil.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/util/CodepointsUtil.java?rev=1905932&r1=1905931&r2=1905932&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/util/CodepointsUtil.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/util/CodepointsUtil.java Mon Dec 12 14:59:35 2022
@@ -23,7 +23,7 @@ import java.util.Iterator;
public class CodepointsUtil {
public static Iterator<String> iteratorFor(String text) {
return text.codePoints()
- .mapToObj(codePoint -> new StringBuilder().appendCodePoint(codePoint).toString())
+ .mapToObj(codePoint -> new String(Character.toChars(codePoint)))
.iterator();
}
}
\ No newline at end of file
Modified: poi/trunk/poi/src/test/java/org/apache/poi/util/TestCodepointsUtil.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/util/TestCodepointsUtil.java?rev=1905932&r1=1905931&r2=1905932&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/util/TestCodepointsUtil.java (original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/util/TestCodepointsUtil.java Mon Dec 12 14:59:35 2022
@@ -35,7 +35,6 @@ class TestCodepointsUtil {
void testIterator() {
final String unicodeSurrogates = "\uD835\uDF4A\uD835\uDF4B\uD835\uDF4C\uD835\uDF4D\uD835\uDF4E"
+ "abcdef123456";
- Iterator<String> sci = CodepointsUtil.iteratorFor(unicodeSurrogates);
List<String> codePoints = new ArrayList<>();
CodepointsUtil.iteratorFor(unicodeSurrogates).forEachRemaining(codePoints::add);
assertEquals(17, codePoints.size());
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org