[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1727: DRILL-7145: Exceptions happened during retrieving values from ValueVe…

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #1727: DRILL-7145: Exceptions happened during retrieving values from ValueVe…
URL: https://github.com/apache/drill/pull/1727#discussion_r271258333
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUserConnection.java
 ##########
 @@ -151,7 +151,7 @@ public void sendData(RpcOutcomeListener<Ack> listener, QueryWritableBatch result
         loader.clear();
       }
     } catch (Exception e) {
-      exception = UserException.systemError(e).build(logger);
+      throw UserException.systemError(e).build(logger);
 
 Review comment:
   I don't think we should throw an exception here. We should stick to original approach and store it but just add method getException() inAbstractDisposableUserClientConnection class, similar to getError(). And then do proper handling of both.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services