[jira] [Commented] (TINKERPOP-2131) NoConnectionAvailableException doesn't reveal the reason

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741618#comment-16741618 ] 

ASF GitHub Bot commented on TINKERPOP-2131:
-------------------------------------------

FlorianHockmann commented on pull request #1039: TINKERPOP-2131 Gremlin.Net: Better explain connection pool exceptions
URL: https://github.com/apache/tinkerpop/pull/1039
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2131
   
   Two new exception classes are added to better reveal the reason for a `NoConnectionAvailableException`:
   * The pool is empty because the server is unavailable
       -> `ServerUnavailableException`
   * All connections have reached the max in-flight requests limit
       -> `ConnectionPoolBusyException`
   Both extend `NoConnectionAvailableException` so this is a non-breaking change.
   
   VOTE +1
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> NoConnectionAvailableException doesn't reveal the reason
> --------------------------------------------------------
>
>                 Key: TINKERPOP-2131
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2131
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet
>    Affects Versions: 3.4.0
>            Reporter: Florian Hockmann
>            Assignee: Florian Hockmann
>            Priority: Minor
>
> The Gremlin.Net driver throws a {{NoConnectionAvailableException}} if it can't get a connection from the pool. This can happen in two cases:
>  # All connections are busy (reached their max requests in flight limit)
>  # The pool is empty, e.g., because the server isn't reachable
> Unfortunately, it's currently impossible to tell from the exception which of these cases caused the exception. The exception message should contain this information as the first case means that users should probably increase the limits whereas the second case just means that there is a general connectivity problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)