You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by vh...@apache.org on 2025/04/10 08:57:57 UTC

(hudi) 01/02: [HUDI-9288] Fixing HoodieFileGroup api related to uncommitted slices (#13125)

This is an automated email from the ASF dual-hosted git repository.

vhs pushed a commit to branch release-1.0.2
in repository https://gitbox.apache.org/repos/asf/hudi.git

commit 07b171214511bc81e9c555cf76ab618615b7a231
Author: Tim Brown <ti...@onehouse.ai>
AuthorDate: Wed Apr 9 23:17:54 2025 -0500

    [HUDI-9288] Fixing HoodieFileGroup api related to uncommitted slices (#13125)
    
    (cherry picked from commit 500d4b9acd9280a1484b3ca57c8e17a4c7725a2f)
---
 .../src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java     | 2 +-
 .../src/test/java/org/apache/hudi/common/model/TestHoodieFileGroup.java | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java b/hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java
index 1d6162ecf11..6903954f374 100644
--- a/hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java
+++ b/hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java
@@ -183,7 +183,7 @@ public class HoodieFileGroup implements Serializable {
   }
 
   public Stream<FileSlice> getAllFileSlicesBeforeOn(String maxInstantTime) {
-    return fileSlices.values().stream().filter(slice -> compareTimestamps(slice.getBaseInstantTime(), LESSER_THAN_OR_EQUALS, maxInstantTime));
+    return getAllFileSlices().filter(slice -> compareTimestamps(slice.getBaseInstantTime(), LESSER_THAN_OR_EQUALS, maxInstantTime));
   }
 
   /**
diff --git a/hudi-hadoop-common/src/test/java/org/apache/hudi/common/model/TestHoodieFileGroup.java b/hudi-hadoop-common/src/test/java/org/apache/hudi/common/model/TestHoodieFileGroup.java
index 8c75033b2ce..1ef5354a239 100644
--- a/hudi-hadoop-common/src/test/java/org/apache/hudi/common/model/TestHoodieFileGroup.java
+++ b/hudi-hadoop-common/src/test/java/org/apache/hudi/common/model/TestHoodieFileGroup.java
@@ -66,6 +66,7 @@ public class TestHoodieFileGroup {
       fileGroup.addBaseFile(baseFile);
     }
     assertEquals(2, fileGroup.getAllFileSlices().count());
+    assertEquals(2, fileGroup.getAllFileSlicesBeforeOn("002").count());
     assertFalse(fileGroup.getAllFileSlices().anyMatch(s -> s.getBaseInstantTime().equals("002")));
     assertEquals(3, fileGroup.getAllFileSlicesIncludingInflight().count());
     assertEquals("001", fileGroup.getLatestFileSlice().get().getBaseInstantTime());