You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/06/13 07:17:00 UTC
[jira] [Work logged] (GOBBLIN-1835) Upgrade Iceberg Version from 0.11.1 to 1.2.0
[ https://issues.apache.org/jira/browse/GOBBLIN-1835?focusedWorklogId=865105&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865105 ]
ASF GitHub Bot logged work on GOBBLIN-1835:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/23 07:16
Start Date: 13/Jun/23 07:16
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3697:
URL: https://github.com/apache/gobblin/pull/3697#discussion_r1227635122
##########
gobblin-iceberg/src/test/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriterTest.java:
##########
@@ -365,12 +364,6 @@ public void testFaultTolerant() throws Exception {
new LongWatermark(52L))));
Assert.assertEquals(gobblinMCEWriter.getDatasetErrorMap().size(), 1);
Assert.assertEquals(gobblinMCEWriter.getDatasetErrorMap().values().iterator().next().size(), 1);
- Assert.assertEquals(gobblinMCEWriter.getDatasetErrorMap()
- .get(new File(tmpDir, "testDB/testTopic").getAbsolutePath())
- .get("hivedb.testTopic").get(0).lowWatermark, 50L);
- Assert.assertEquals(gobblinMCEWriter.getDatasetErrorMap()
- .get(new File(tmpDir, "testDB/testTopic").getAbsolutePath())
- .get("hivedb.testTopic").get(0).highWatermark, 52L);
Review Comment:
looks like there's still expected to be one element in the errors map, however we're no longer verifying the value. why remove validation entirely, rather than, say, update, if need be? now it looks like a potential oversight...
Issue Time Tracking
-------------------
Worklog Id: (was: 865105)
Time Spent: 1h (was: 50m)
> Upgrade Iceberg Version from 0.11.1 to 1.2.0
> --------------------------------------------
>
> Key: GOBBLIN-1835
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1835
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)