You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/10 06:17:06 UTC
[GitHub] [ratis-thirdparty] codings-dan opened a new pull request, #37: RATIS-1664. Relocate org.slf4j.* in ratis-thirdparty-misc
codings-dan opened a new pull request, #37:
URL: https://github.com/apache/ratis-thirdparty/pull/37
see https://issues.apache.org/jira/browse/RATIS-1664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] codings-dan commented on pull request #37: RATIS-1664. Relocate org.slf4j.* in ratis-thirdparty-misc
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #37:
URL: https://github.com/apache/ratis-thirdparty/pull/37#issuecomment-1210598029
@szetszwo Thanks for helping review, I have updated code, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] szetszwo merged pull request #37: RATIS-1664. Exclude org.slf4j.* in ratis-thirdparty-misc
Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #37:
URL: https://github.com/apache/ratis-thirdparty/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] codings-dan commented on pull request #37: RATIS-1664. Exclude org.slf4j.* in ratis-thirdparty-misc
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #37:
URL: https://github.com/apache/ratis-thirdparty/pull/37#issuecomment-1211933081
@szetszwo I have updated the code. For `io.perfmark` and `org.acplt`, I know we should exclude them, but I don't understand what we should do for `com.google.api.grpc:proto-google-common-protos` and just exclude it. If incorrent, please let me know, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] szetszwo commented on pull request #37: RATIS-1664. Relocate org.slf4j.* in ratis-thirdparty-misc
Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #37:
URL: https://github.com/apache/ratis-thirdparty/pull/37#issuecomment-1210352177
@codings-dan , we should exclude org.slf4j.* but not relocate it. The thirdparty jar should only include the shaded classes but not all the classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] szetszwo commented on pull request #37: RATIS-1664. Exclude org.slf4j.* in ratis-thirdparty-misc
Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #37:
URL: https://github.com/apache/ratis-thirdparty/pull/37#issuecomment-1211032664
For `io.perfmark` and `org.acplt`, we probably should exclude them but not relocate them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org