You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/11/10 05:34:33 UTC
[GitHub] [openwhisk] upgle opened a new pull request #5025: Hide version in activation's path generated by generateFallbackActivation
upgle opened a new pull request #5025:
URL: https://github.com/apache/openwhisk/pull/5025
<!--- Provide a concise summary of your changes in the Title -->
## Description
If the activation is generated by the `generateFallbackActivation` method in the InvokerReactive, it contains the version in the path annotation.
In this case, the ES activation store can't search for activations by the name without version.
And also, all other components that generate activation don't store version, but only InvokerReactive stores the version in the path annotation. It must be consistent.
https://github.com/apache/openwhisk/blob/a1ba98778e3db80a06fe707c47c5f4c05d8b85ee/core/controller/src/main/scala/org/apache/openwhisk/core/controller/actions/PrimitiveActions.scala#L589
https://github.com/apache/openwhisk/blob/a1ba98778e3db80a06fe707c47c5f4c05d8b85ee/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerProxy.scala#L1070
https://github.com/apache/openwhisk/blob/8759cadeea6101a3693aac1d34d4069f516d5558/core/controller/src/main/scala/org/apache/openwhisk/core/controller/actions/SequenceActions.scala#L243
#### Path annotation
```json
{
"annotations": [
{
"key": "kind",
"value": "nodejs:10"
},
{
"key": "path",
"value": "seonghyun/a2@0.0.154"
}
]
}
```
#### Path annotation (expected)
```json
{
"annotations": [
{
"key": "kind",
"value": "nodejs:10"
},
{
"key": "path",
"value": "seonghyun/a2"
}
]
}
```
## Related issue and scope
- None
## My changes affect the following components
- [x] Data stores (activation format)
## Types of changes
- [x] Enhancement or new feature (adds new functionality).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [x] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-io commented on pull request #5025: Hide version in activation's path generated by generateFallbackActivation
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5025:
URL: https://github.com/apache/openwhisk/pull/5025#issuecomment-725316005
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5025?src=pr&el=h1) Report
> Merging [#5025](https://codecov.io/gh/apache/openwhisk/pull/5025?src=pr&el=desc) (06fc8b6) into [master](https://codecov.io/gh/apache/openwhisk/commit/cb1645052dab33d18e5d0c059df6d1ef7ce3a6de?el=desc) (cb16450) will **decrease** coverage by `6.85%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/5025?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5025 +/- ##
==========================================
- Coverage 83.77% 76.91% -6.86%
==========================================
Files 202 202
Lines 9787 9787
Branches 432 432
==========================================
- Hits 8199 7528 -671
- Misses 1588 2259 +671
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/5025?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pache/openwhisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/openwhisk/pull/5025/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `80.00% <ø> (ø)` | |
| [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/5025/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/5025/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/ChangeFeedConsumer.scala](https://codecov.io/gh/apache/openwhisk/pull/5025/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRDb25zdW1lci5zY2FsYQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/5025/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0.00% <0.00%> (-95.85%)` | :arrow_down: |
| [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/openwhisk/pull/5025/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0.00% <0.00%> (-93.90%)` | :arrow_down: |
| [...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/5025/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3JDb25maWcuc2NhbGE=) | `0.00% <0.00%> (-92.31%)` | :arrow_down: |
| [...enwhisk/connector/kafka/KamonMetricsReporter.scala](https://codecov.io/gh/apache/openwhisk/pull/5025/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYW1vbk1ldHJpY3NSZXBvcnRlci5zY2FsYQ==) | `0.00% <0.00%> (-83.34%)` | :arrow_down: |
| [...e/database/cosmosdb/cache/KafkaEventProducer.scala](https://codecov.io/gh/apache/openwhisk/pull/5025/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0thZmthRXZlbnRQcm9kdWNlci5zY2FsYQ==) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/5025/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0.00% <0.00%> (-74.08%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/openwhisk/pull/5025/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/5025?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5025?src=pr&el=footer). Last update [cb16450...06fc8b6](https://codecov.io/gh/apache/openwhisk/pull/5025?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] rabbah merged pull request #5025: Hide version in activation's path generated by generateFallbackActivation
Posted by GitBox <gi...@apache.org>.
rabbah merged pull request #5025:
URL: https://github.com/apache/openwhisk/pull/5025
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org