You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/10/25 02:44:55 UTC
[jclouds] Revert JCLOUDS-652 so that we don't require java 7 (#585)
This reverts the change that required users to use java language 7.
https://issues.apache.org/jira/browse/JCLOUDS-652
This takes care of the default http driver and single-shot 2GB fixed length posts. Basically, those using JRE7 will work. Those not, can choose a different http driver.
https://issues.apache.org/jira/browse/JCLOUDS-264
You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds adrian.dont-require-java-7
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/585
-- Commit Summary --
* Revert "JCLOUDS-652: Require JDK 7"
* Revert "JCLOUDS-264: Allow payloads greater than 2 GB"
* JCLOUDS-264 Conditionally allow default http driver to support sending >2GB payloads without chunked encoding.
-- File Changes --
M blobstore/src/main/java/org/jclouds/blobstore/config/LocalBlobStore.java (2)
M core/src/main/java/org/jclouds/http/internal/JavaUrlHttpCommandExecutorService.java (42)
M core/src/main/java/org/jclouds/rest/HttpClient.java (3)
M core/src/test/java/org/jclouds/http/JavaUrlHttpCommandExecutorServiceIntegrationTest.java (41)
M project/pom.xml (9)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/585.patch
https://github.com/jclouds/jclouds/pull/585.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1846](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1846/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60467845
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Adrian Cole <no...@github.com>.
picked into master. working through conflicts on 1.8.x
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60490505
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1853](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1853/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60475661
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1333](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1333/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60469690
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7 (#585)
Posted by Adrian Cole <ad...@gmail.com>.
Was in the revert. Happy to take that out if you like.
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Andrew Phillips <no...@github.com>.
>
> public static boolean isMacOSX() {
> String osName = System.getProperty("os.name");
> return osName.contains("OS X");
> }
>
> + public static boolean isJava6() {
> + System.out.println(System.getProperty("java.version", "None??"));
Debugging code?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585/files#r19374921
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1339](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1339/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60470378
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #250](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/250/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60470231
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1847](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1847/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60469108
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Adrian Cole <no...@github.com>.
Whoot! all builders pass. Check out the fancy isolation of filesystem to builds that use jre7+!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60470309
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Adrian Cole <no...@github.com>.
> if (length > 0) {
> - connection.setRequestProperty(CONTENT_LENGTH, String.valueOf(length));
> - connection.setFixedLengthStreamingMode(length);
> + connection.setRequestProperty(CONTENT_LENGTH, length.toString());
> + if (length <= Integer.MAX_VALUE) {
> + connection.setFixedLengthStreamingMode(length.intValue());
> + } else {
> + setFixedLengthStreamingMode(connection, length);
> + }
I don't want to limit this fix to JRE. It is a java api level thing.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585/files#r19376517
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Andrew Phillips <no...@github.com>.
> if (length > 0) {
> - connection.setRequestProperty(CONTENT_LENGTH, String.valueOf(length));
> - connection.setFixedLengthStreamingMode(length);
> + connection.setRequestProperty(CONTENT_LENGTH, length.toString());
> + if (length <= Integer.MAX_VALUE) {
> + connection.setFixedLengthStreamingMode(length.intValue());
> + } else {
> + setFixedLengthStreamingMode(connection, length);
> + }
Actually, comment about this: could we not check here whether we are running on a 6 or 7 JDK? If we're on a 6 JDK, we _know_ the reflective call cannot succeed, so why try?
Or am I missing something here..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585/files#r19376498
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1338](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1338/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60470081
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Adrian Cole <no...@github.com>.
> @@ -549,7 +549,7 @@ public BlobMetadata blobMetadata(String containerName, String key) {
> try {
> Blob blob = getBlob(containerName, key);
> return blob != null ? (BlobMetadata) BlobStoreUtils.copy(blob.getMetadata()) : null;
> - } catch (Exception e) {
> + } catch (RuntimeException e) {
dunno how changing language levels made this happen, but whatev!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585/files#r19371863
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1336](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1336/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60469869
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Andrew Phillips <no...@github.com>.
> Check out the fancy isolation of filesystem to builds that use jre7+!
Nice, indeed!
+1 - code looks good to me. One minor comment about the new profiles: name them both `jre1.7` or so, rather than `jre1.7-blobstores` and `jre1.7-apis`? They're both supposed to be active at the same time, and with one profile name it's easy to see what the overall setup is supposed to be simply by adding `-Pjre1.7` to the command line.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60489103
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #252](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/252/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60489569
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1848](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1848/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60470290
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Adrian Cole <no...@github.com>.
> @@ -192,6 +193,17 @@ protected HttpURLConnection convert(HttpRequest request) throws IOException, Int
> return connection;
> }
>
> + /** Uses {@link HttpURLConnection#setFixedLengthStreamingMode(long)} if possible or throws if not. */
> + private void setFixedLengthStreamingMode(HttpURLConnection connection, long length) {
done
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585/files#r19376518
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1855](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1855/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60493507
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1852](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1852/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60474418
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #245](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/245/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60469356
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1851](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1851/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60473348
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Adrian Cole <no...@github.com>.
ok fixes are in. awaiting buildhive again.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60489536
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1334](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1334/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60469739
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1854](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1854/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60490868
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #247](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/247/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60469443
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1850](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1850/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60472364
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #251](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/251/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60489644
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #241](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/241/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60466073
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1330](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1330/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60466939
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #244](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/244/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60469289
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1331](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1331/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60467275
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1332](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1332/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60467278
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #242](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/242/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60466509
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1340](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1340/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60489951
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #249](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/249/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60469638
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Andrew Phillips <no...@github.com>.
> @@ -192,6 +193,17 @@ protected HttpURLConnection convert(HttpRequest request) throws IOException, Int
> return connection;
> }
>
> + /** Uses {@link HttpURLConnection#setFixedLengthStreamingMode(long)} if possible or throws if not. */
> + private void setFixedLengthStreamingMode(HttpURLConnection connection, long length) {
[minor] Can be static?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585/files#r19376440
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Adrian Cole <no...@github.com>.
@demobox fyi, the activation properties will apply so not necessarily important to name the profiles the same. at any rate, that's not a bad suggestion, so will sort.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60489381
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Andrew Phillips <no...@github.com>.
>
> public static boolean isMacOSX() {
> String osName = System.getProperty("os.name");
> return osName.contains("OS X");
> }
>
> + public static boolean isJava6() {
> + System.out.println(System.getProperty("java.version", "None??"));
> Happy to take that out if you like.
That would be nice, thanks. Or I can remove in a follow-up if you prefer.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585/files#r19376450
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #248](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/248/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60469548
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Adrian Cole <no...@github.com>.
> @@ -192,6 +194,28 @@ protected HttpURLConnection convert(HttpRequest request) throws IOException, Int
> return connection;
> }
>
> + /** Uses {@link HttpURLConnection#setFixedLengthStreamingMode(long)} if possible or throws if not. */
> + private synchronized void setFixedLengthStreamingMode(HttpURLConnection connection, long length) {
> + if (setFixedLengthStreamingMode != null) {
note: perfectly happy to make simplify this by not caching the method ref, if desired.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585/files#r19371893
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1341](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1341/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60490343
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1335](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1335/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60469789
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1337](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1337/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60469999
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Adrian Cole <no...@github.com>.
> if (length > 0) {
> - connection.setRequestProperty(CONTENT_LENGTH, String.valueOf(length));
> - connection.setFixedLengthStreamingMode(length);
> + connection.setRequestProperty(CONTENT_LENGTH, length.toString());
> + if (length <= Integer.MAX_VALUE) {
> + connection.setFixedLengthStreamingMode(length.intValue());
> + } else {
> + setFixedLengthStreamingMode(connection, length);
> + }
Ex. This is really about what this class supports. More of an interest wrt android (although still uploading >2GB in one shot is dubious and I'm really surprised we've still not started or landed the MPU tool!)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585/files#r19376537
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #243](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/243/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60466545
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Adrian Cole <no...@github.com>.
Closed #585.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#event-183672525
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #246](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/246/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60469381
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1849](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1849/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585#issuecomment-60471307
Re: [jclouds] Revert JCLOUDS-652 so that we don't require java 7
(#585)
Posted by Adrian Cole <no...@github.com>.
> @@ -201,8 +201,9 @@
>
> <properties>
> <clojure.version>1.3.0</clojure.version>
> - <maven.compile.source>1.7</maven.compile.source>
> - <maven.compile.target>1.7</maven.compile.target>
> + <maven.compile.source>1.6</maven.compile.source>
> + <maven.compile.target>1.6</maven.compile.target>
> + <maven.compile.optimize>true</maven.compile.optimize>
this was here earlier.. can take it out if desired.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/585/files#r19371923