You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/07/30 17:07:24 UTC

Review Request 24104: Fixing test_escalations_ipaddresses.py - Passing type Isolated while listing Networks to avoid inclusion of shared networks in the list

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24104/
-----------------------------------------------------------

Review request for cloudstack and Girish Shilamkar.


Repository: cloudstack-git


Description
-------

Network.list was also listing the shared network already prese.t Hence it was failing while asserrting the number of networks in the account&domain.
Passing netwoktype as Isolated to get the correct number of Networks as we are not creating any shared network through the test.


Diffs
-----

  test/integration/component/test_escalations_ipaddresses.py 411dae0 

Diff: https://reviews.apache.org/r/24104/diff/


Testing
-------

Yes.


Thanks,

Gaurav Aradhye


Re: Review Request 24104: Fixing test_escalations_ipaddresses.py - Passing type Isolated while listing Networks to avoid inclusion of shared networks in the list

Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24104/
-----------------------------------------------------------

(Updated July 30, 2014, 9:28 p.m.)


Review request for cloudstack and Girish Shilamkar.


Changes
-------

updated patch with two more test suites requiring same changes.


Repository: cloudstack-git


Description
-------

Network.list was also listing the shared network already prese.t Hence it was failing while asserrting the number of networks in the account&domain.
Passing netwoktype as Isolated to get the correct number of Networks as we are not creating any shared network through the test.


Diffs (updated)
-----

  test/integration/component/test_escalations_instances.py ef939f1 
  test/integration/component/test_escalations_ipaddresses.py 411dae0 
  test/integration/component/test_escalations_networks.py 2bf5735 

Diff: https://reviews.apache.org/r/24104/diff/


Testing
-------

Yes.


Thanks,

Gaurav Aradhye