You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/04/01 00:43:19 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #2398: Core: Implement HasTableOperations in metadata and txn tables

rdblue commented on a change in pull request #2398:
URL: https://github.com/apache/iceberg/pull/2398#discussion_r605306807



##########
File path: core/src/main/java/org/apache/iceberg/BaseMetadataTable.java
##########
@@ -195,12 +218,9 @@ public String toString() {
     return name();
   }
 
-  abstract String metadataLocation();

Review comment:
       This was package-private so it should be okay to remove it. I think using `HasTableOperations` is a better way to access the metadata location.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org