[GitHub] [airflow] guptakumartanuj commented on a change in pull request #5037: [AIRFLOW-4237] Including Try Number of Task in Gantt Chart

[GitBox <gi...@apache.org>]

guptakumartanuj commented on a change in pull request #5037: [AIRFLOW-4237] Including Try Number of Task in Gantt Chart
URL: https://github.com/apache/airflow/pull/5037#discussion_r284298152
 
 

 ##########
 File path: airflow/www/static/js/gantt-chart-d3v2.js
 ##########
 @@ -32,11 +32,12 @@ d3.gantt = function() {
     .html(function(d) {
       var s = ""
       s += "<div class='row'>";
-      s += "<div class='col-md-3'>start:<br/>end:<br/>duration:</div>"
+      s += "<div class='col-md-3'>start:<br/>end:<br/>duration:<br/>try_number:</div>"
       s += "<div class='col-md-9'><span style='color: #AAA'> "
       s += d.isoStart + "<br/>";
       s += d.isoEnd + "<br/>";
       s += convertSecsToHumanReadable(d.duration) + "<br/>";
+      s += d.try_number + "<br/>";
 
 Review comment:
   Just wanted to keep it in terms of Airflow Terminology. Anyways changed it to try_count.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services