You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ivan Zhakov <iv...@visualsvn.com> on 2015/02/09 13:15:55 UTC
Re: svn commit: r1654810 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py
On 26 January 2015 at 17:17, <rh...@apache.org> wrote:
> Author: rhuijben
> Date: Mon Jan 26 14:17:25 2015
> New Revision: 1654810
>
> URL: http://svn.apache.org/r1654810
> Log:
> Following up on r1654794, add a related test that verifies the author value
> retrieved with the stat ra functions.
>
> * subversion/tests/cmdline/prop_tests.py
> (xml_unsafe_author2): New test.
> (test_list): Add xml_unsafe_author2.
>
> Modified:
> subversion/trunk/subversion/tests/cmdline/prop_tests.py
>
> Modified: subversion/trunk/subversion/tests/cmdline/prop_tests.py
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/prop_tests.py?rev=1654810&r1=1654809&r2=1654810&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/tests/cmdline/prop_tests.py (original)
> +++ subversion/trunk/subversion/tests/cmdline/prop_tests.py Mon Jan 26 14:17:25 2015
> @@ -2669,6 +2669,46 @@ def xml_unsafe_author(sbox):
> 'proplist', '--revprop', '-r', '1', '-v',
> wc_dir)
>
> +@Issue(4415)
> +def xml_unsafe_author2(sbox):
> + "svn:author with XML unsafe chars 2"
> +
> + sbox.build(create_wc = False)
> + repo_url = sbox.repo_url
> +
> + svntest.actions.enable_revprop_changes(sbox.repo_dir)
> +
> + # client sends svn:author (via PROPPATCH for DAV)
> + svntest.actions.run_and_verify_svn(None, None, [],
> + 'propset', '--revprop', '-r', '1',
> + 'svn:author', 'foo\bbar', repo_url)
> +
> + # Ensure a stable date
> + svntest.actions.run_and_verify_svn(None, None, [],
> + 'propset', '--revprop', '-r', '1',
> + 'svn:date', '2000-01-01T12:00:00.0Z',
> + repo_url)
> +
> + if svntest.main.is_ra_type_dav():
> + # This receives the filtered author (but that is better than an Xml fail)
> + expected_author = 'foobar'
> + else:
> + expected_author = 'foo\bbar'
> +
> + expected_output = svntest.verify.UnorderedOutput([
> + ' 1 %-8s Jan 01 2000 ./\n' % expected_author,
> + ' 1 %-8s Jan 01 2000 A/\n' % expected_author,
> + ' 1 %-8s 25 Jan 01 2000 iota\n' % expected_author
> + ])
Hi Bert,
This test is failing on system with non-US default locale, because
'svn ls -v' prints date in locale depended format.
--
Ivan Zhakov
Re: svn commit: r1654810 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On 9 February 2015 at 18:22, Bert Huijben <be...@qqmail.nl> wrote:
>
>
>> -----Original Message-----
>> From: Branko Čibej [mailto:brane@wandisco.com]
>> Sent: maandag 9 februari 2015 16:04
>> To: dev@subversion.apache.org
>> Subject: Re: svn commit: r1654810 -
>> /subversion/trunk/subversion/tests/cmdline/prop_tests.py
>>
>> On 09.02.2015 14:40, Philip Martin wrote:
>> > Ivan Zhakov <iv...@visualsvn.com> writes:
>> >
>> >> On 9 February 2015 at 16:22, Philip Martin <ph...@wandisco.com>
>> wrote:
>> >>> "Bert Huijben" <be...@qqmail.nl> writes:
>> >>>
>> >>>> A few years ago we added code to the test suite that should force the
>> >>>> locale to the expected locale and that works for me...
>> >>> build/run_tests.py
>> >>>
>> >>> # Ensure the compiled C tests use a known locale (Python tests set the
>> locale
>> >>> # explicitly).
>> >>> os.environ['LC_ALL'] = 'C'
>> >>>
>> >>> subversion/tests/cmdline/svntest/main.py
>> >>>
>> >>> # Set C locale for command line programs
>> >>> os.environ['LC_ALL'] = 'C'
>> >>>
>> >> It seems this code doesn't work if Windows is configured to use non-US
>> >> locale as *system* locale.
>> > Does setting LANGUAGE work? Or perhaps LANG?
>>
>> No; Windows doesn't have the concept of per-process locales, only
>> per-window input methods.
>
> Why does this then change the output of my dates from English to Dutch?
>
Changing LC_ALL environment variable doesn't affect 'svn ls -v' output
on my Windows 7 machine:
$ set LC_ALL=en_US
$ svn ls -v
D:\Ivan\SVN\trunk>svn ls -v CHANGES
1681897 breser 309451 май 27 04:10 CHANGES
> Windows itself doesn't support this, but the C runtime library certainly does support this.
>
I've looked through VS2013 C runtime source code and didn't find code
that access LC_ALL environment variable.
I'm going to tweak this test to use xml mode to have locale
independent output: test failures are bad.
--
Ivan Zhakov
RE: svn commit: r1654810 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: Branko Čibej [mailto:brane@wandisco.com]
> Sent: maandag 9 februari 2015 16:04
> To: dev@subversion.apache.org
> Subject: Re: svn commit: r1654810 -
> /subversion/trunk/subversion/tests/cmdline/prop_tests.py
>
> On 09.02.2015 14:40, Philip Martin wrote:
> > Ivan Zhakov <iv...@visualsvn.com> writes:
> >
> >> On 9 February 2015 at 16:22, Philip Martin <ph...@wandisco.com>
> wrote:
> >>> "Bert Huijben" <be...@qqmail.nl> writes:
> >>>
> >>>> A few years ago we added code to the test suite that should force the
> >>>> locale to the expected locale and that works for me...
> >>> build/run_tests.py
> >>>
> >>> # Ensure the compiled C tests use a known locale (Python tests set the
> locale
> >>> # explicitly).
> >>> os.environ['LC_ALL'] = 'C'
> >>>
> >>> subversion/tests/cmdline/svntest/main.py
> >>>
> >>> # Set C locale for command line programs
> >>> os.environ['LC_ALL'] = 'C'
> >>>
> >> It seems this code doesn't work if Windows is configured to use non-US
> >> locale as *system* locale.
> > Does setting LANGUAGE work? Or perhaps LANG?
>
> No; Windows doesn't have the concept of per-process locales, only
> per-window input methods.
Why does this then change the output of my dates from English to Dutch?
Windows itself doesn't support this, but the C runtime library certainly does support this.
Bert
Re: svn commit: r1654810 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py
Posted by Branko Čibej <br...@wandisco.com>.
On 09.02.2015 14:40, Philip Martin wrote:
> Ivan Zhakov <iv...@visualsvn.com> writes:
>
>> On 9 February 2015 at 16:22, Philip Martin <ph...@wandisco.com> wrote:
>>> "Bert Huijben" <be...@qqmail.nl> writes:
>>>
>>>> A few years ago we added code to the test suite that should force the
>>>> locale to the expected locale and that works for me...
>>> build/run_tests.py
>>>
>>> # Ensure the compiled C tests use a known locale (Python tests set the locale
>>> # explicitly).
>>> os.environ['LC_ALL'] = 'C'
>>>
>>> subversion/tests/cmdline/svntest/main.py
>>>
>>> # Set C locale for command line programs
>>> os.environ['LC_ALL'] = 'C'
>>>
>> It seems this code doesn't work if Windows is configured to use non-US
>> locale as *system* locale.
> Does setting LANGUAGE work? Or perhaps LANG?
No; Windows doesn't have the concept of per-process locales, only
per-window input methods.
-- Brane
Re: svn commit: r1654810 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py
Posted by Philip Martin <ph...@wandisco.com>.
Ivan Zhakov <iv...@visualsvn.com> writes:
> On 9 February 2015 at 16:22, Philip Martin <ph...@wandisco.com> wrote:
>> "Bert Huijben" <be...@qqmail.nl> writes:
>>
>>> A few years ago we added code to the test suite that should force the
>>> locale to the expected locale and that works for me...
>>
>> build/run_tests.py
>>
>> # Ensure the compiled C tests use a known locale (Python tests set the locale
>> # explicitly).
>> os.environ['LC_ALL'] = 'C'
>>
>> subversion/tests/cmdline/svntest/main.py
>>
>> # Set C locale for command line programs
>> os.environ['LC_ALL'] = 'C'
>>
> It seems this code doesn't work if Windows is configured to use non-US
> locale as *system* locale.
Does setting LANGUAGE work? Or perhaps LANG?
--
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Re: svn commit: r1654810 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On 9 February 2015 at 16:22, Philip Martin <ph...@wandisco.com> wrote:
> "Bert Huijben" <be...@qqmail.nl> writes:
>
>> A few years ago we added code to the test suite that should force the
>> locale to the expected locale and that works for me...
>
> build/run_tests.py
>
> # Ensure the compiled C tests use a known locale (Python tests set the locale
> # explicitly).
> os.environ['LC_ALL'] = 'C'
>
> subversion/tests/cmdline/svntest/main.py
>
> # Set C locale for command line programs
> os.environ['LC_ALL'] = 'C'
>
It seems this code doesn't work if Windows is configured to use non-US
locale as *system* locale.
--
Ivan Zhakov
Re: svn commit: r1654810 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py
Posted by Philip Martin <ph...@wandisco.com>.
Philip Martin <ph...@codematters.co.uk> writes:
> Philip Martin <ph...@wandisco.com> writes:
>
>> # Set C locale for command line programs
>> os.environ['LC_ALL'] = 'C'
>
> Hmm, setting LC_ALL may not do what we want on the command line:
>
> $ LC_ALL=de_DE svn
> Type 'svn help' for usage.
> $ LC_ALL=de_DE svn ls -v wc/A/f
> 1 pm 2 Feb 09 12:32 f
That's my Debian box with LANGUAGE set. I have a Fedora laptop that
doesn't have LANGUAGE set and there setting LC_ALL is enough:
$ LC_ALL=de_DE svn
Geben Sie »svn help« für weitere Hilfe ein.
Unsetting LANGUAGE makes LC_ALL take effect on Debian:
$ (unset LANGUAGE ; LC_ALL=de_DE svn)
Geben Sie »svn help« für weitere Hilfe ein.
and LANGUAGE overrides LC_ALL on Fedora:
$ LANGUAGE=en_GB LC_ALL=de_DE svn
Type 'svn help' for usage.
--
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Re: svn commit: r1654810 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py
Posted by Philip Martin <ph...@codematters.co.uk>.
Philip Martin <ph...@wandisco.com> writes:
> # Set C locale for command line programs
> os.environ['LC_ALL'] = 'C'
Hmm, setting LC_ALL may not do what we want on the command line:
$ LC_ALL=de_DE svn
Type 'svn help' for usage.
$ LC_ALL=de_DE svn ls -v wc/A/f
1 pm 2 Feb 09 12:32 f
To get German I need to set LANGUAGE:
$ LANGUAGE=de_DE svn
Geben Sie »svn help« für weitere Hilfe ein.
$ LANGUAGE=de_DE svn ls -v wc/A/f
1 pm 2 09. Feb 12:32 f
Setting LC_ALL doesn't alter LANGUAGE:
$ (export LC_ALL=de_DE ; locale )
(export LC_ALL=de_DE ; locale)
LANG=en_GB.UTF-8
LANGUAGE=en_GB:en
LC_CTYPE="de_DE"
LC_NUMERIC="de_DE"
LC_TIME="de_DE"
LC_COLLATE="de_DE"
LC_MONETARY="de_DE"
LC_MESSAGES="de_DE"
LC_PAPER="de_DE"
LC_NAME="de_DE"
LC_ADDRESS="de_DE"
LC_TELEPHONE="de_DE"
LC_MEASUREMENT="de_DE"
LC_IDENTIFICATION="de_DE"
LC_ALL=de_DE
--
Philip
Re: svn commit: r1654810 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py
Posted by Philip Martin <ph...@wandisco.com>.
"Bert Huijben" <be...@qqmail.nl> writes:
> A few years ago we added code to the test suite that should force the
> locale to the expected locale and that works for me...
build/run_tests.py
# Ensure the compiled C tests use a known locale (Python tests set the locale
# explicitly).
os.environ['LC_ALL'] = 'C'
subversion/tests/cmdline/svntest/main.py
# Set C locale for command line programs
os.environ['LC_ALL'] = 'C'
--
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
RE: svn commit: r1654810 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: Ivan Zhakov [mailto:ivan@visualsvn.com]
> Sent: maandag 9 februari 2015 14:00
> To: Bert Huijben
> Cc: Subversion Development
> Subject: Re: svn commit: r1654810 -
> /subversion/trunk/subversion/tests/cmdline/prop_tests.py
>
> On 9 February 2015 at 15:54, Bert Huijben <be...@qqmail.nl> wrote:
> >
> >
> >> -----Original Message-----
> >> From: Ivan Zhakov [mailto:ivan@visualsvn.com]
> >> Sent: maandag 9 februari 2015 13:16
> >> To: Subversion Development
> >> Cc: Bert Huijben
> >> Subject: Re: svn commit: r1654810 -
> >> /subversion/trunk/subversion/tests/cmdline/prop_tests.py
> >>
> >> On 26 January 2015 at 17:17, <rh...@apache.org> wrote:
> >> > Author: rhuijben
> >> > Date: Mon Jan 26 14:17:25 2015
> >> > New Revision: 1654810
> >> >
> >> > URL: http://svn.apache.org/r1654810
> >> > Log:
> >> > Following up on r1654794, add a related test that verifies the author value
> >> > retrieved with the stat ra functions.
> >> >
> >> > * subversion/tests/cmdline/prop_tests.py
> >> > (xml_unsafe_author2): New test.
> >> > (test_list): Add xml_unsafe_author2.
> >> >
> >> > Modified:
> >> > subversion/trunk/subversion/tests/cmdline/prop_tests.py
> >> >
> >> > Modified: subversion/trunk/subversion/tests/cmdline/prop_tests.py
> >> > URL:
> >>
> http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/prop_
> >> tests.py?rev=1654810&r1=1654809&r2=1654810&view=diff
> >> >
> >>
> ================================================================
> >> ==============
> >> > --- subversion/trunk/subversion/tests/cmdline/prop_tests.py (original)
> >> > +++ subversion/trunk/subversion/tests/cmdline/prop_tests.py Mon Jan 26
> >> 14:17:25 2015
> >> > @@ -2669,6 +2669,46 @@ def xml_unsafe_author(sbox):
> >> > 'proplist', '--revprop', '-r', '1', '-v',
> >> > wc_dir)
> >> >
> >> > +@Issue(4415)
> >> > +def xml_unsafe_author2(sbox):
> >> > + "svn:author with XML unsafe chars 2"
> >> > +
> >> > + sbox.build(create_wc = False)
> >> > + repo_url = sbox.repo_url
> >> > +
> >> > + svntest.actions.enable_revprop_changes(sbox.repo_dir)
> >> > +
> >> > + # client sends svn:author (via PROPPATCH for DAV)
> >> > + svntest.actions.run_and_verify_svn(None, None, [],
> >> > + 'propset', '--revprop', '-r', '1',
> >> > + 'svn:author', 'foo\bbar', repo_url)
> >> > +
> >> > + # Ensure a stable date
> >> > + svntest.actions.run_and_verify_svn(None, None, [],
> >> > + 'propset', '--revprop', '-r', '1',
> >> > + 'svn:date', '2000-01-01T12:00:00.0Z',
> >> > + repo_url)
> >> > +
> >> > + if svntest.main.is_ra_type_dav():
> >> > + # This receives the filtered author (but that is better than an Xml fail)
> >> > + expected_author = 'foobar'
> >> > + else:
> >> > + expected_author = 'foo\bbar'
> >> > +
> >> > + expected_output = svntest.verify.UnorderedOutput([
> >> > + ' 1 %-8s Jan 01 2000 ./\n' % expected_author,
> >> > + ' 1 %-8s Jan 01 2000 A/\n' % expected_author,
> >> > + ' 1 %-8s 25 Jan 01 2000 iota\n' % expected_author
> >> > + ])
> >> Hi Bert,
> >>
> >> This test is failing on system with non-US default locale, because
> >> 'svn ls -v' prints date in locale depended format.
> >
> > I run my system with Dutch date formats but still see the US format when
> running the tests (because we force a locale somewhere), while a normal
> invocation of 'svn -v' does show it in a different format.
> > (In my case 'Jan' would just be 'jan' (different capitalization))
> >
> > Are you sure that there isn't a different problem here?
> >
> > The test can probably be tweaked to use some kind of regex matching, but I
> doubt whether that is necessary.
> >
> There are several settings in Windows that affect locale used for
> applications. Do you have configured "Language for non-Unicode
> programs" to Dutch on your system?
We use apr_strftime() to format the sting and it behaves different when I run it in the test suite and normally.
I would be very surprised if this function would use *multiple different* locale settings at the same time.
If that is the case we might have completely different problems that we should look at. It appears we also assume that this function always delivers proper utf-8 strings, which after looking through the source of both apr and the Visual C++ CRT sourcecode that implements strftime think is a bad assumption.
A few years ago we added code to the test suite that should force the locale to the expected locale and that works for me...
Before further ignoring the problem by just making the test pass I think we should look at that.
Bert
Re: svn commit: r1654810 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On 9 February 2015 at 15:54, Bert Huijben <be...@qqmail.nl> wrote:
>
>
>> -----Original Message-----
>> From: Ivan Zhakov [mailto:ivan@visualsvn.com]
>> Sent: maandag 9 februari 2015 13:16
>> To: Subversion Development
>> Cc: Bert Huijben
>> Subject: Re: svn commit: r1654810 -
>> /subversion/trunk/subversion/tests/cmdline/prop_tests.py
>>
>> On 26 January 2015 at 17:17, <rh...@apache.org> wrote:
>> > Author: rhuijben
>> > Date: Mon Jan 26 14:17:25 2015
>> > New Revision: 1654810
>> >
>> > URL: http://svn.apache.org/r1654810
>> > Log:
>> > Following up on r1654794, add a related test that verifies the author value
>> > retrieved with the stat ra functions.
>> >
>> > * subversion/tests/cmdline/prop_tests.py
>> > (xml_unsafe_author2): New test.
>> > (test_list): Add xml_unsafe_author2.
>> >
>> > Modified:
>> > subversion/trunk/subversion/tests/cmdline/prop_tests.py
>> >
>> > Modified: subversion/trunk/subversion/tests/cmdline/prop_tests.py
>> > URL:
>> http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/prop_
>> tests.py?rev=1654810&r1=1654809&r2=1654810&view=diff
>> >
>> ================================================================
>> ==============
>> > --- subversion/trunk/subversion/tests/cmdline/prop_tests.py (original)
>> > +++ subversion/trunk/subversion/tests/cmdline/prop_tests.py Mon Jan 26
>> 14:17:25 2015
>> > @@ -2669,6 +2669,46 @@ def xml_unsafe_author(sbox):
>> > 'proplist', '--revprop', '-r', '1', '-v',
>> > wc_dir)
>> >
>> > +@Issue(4415)
>> > +def xml_unsafe_author2(sbox):
>> > + "svn:author with XML unsafe chars 2"
>> > +
>> > + sbox.build(create_wc = False)
>> > + repo_url = sbox.repo_url
>> > +
>> > + svntest.actions.enable_revprop_changes(sbox.repo_dir)
>> > +
>> > + # client sends svn:author (via PROPPATCH for DAV)
>> > + svntest.actions.run_and_verify_svn(None, None, [],
>> > + 'propset', '--revprop', '-r', '1',
>> > + 'svn:author', 'foo\bbar', repo_url)
>> > +
>> > + # Ensure a stable date
>> > + svntest.actions.run_and_verify_svn(None, None, [],
>> > + 'propset', '--revprop', '-r', '1',
>> > + 'svn:date', '2000-01-01T12:00:00.0Z',
>> > + repo_url)
>> > +
>> > + if svntest.main.is_ra_type_dav():
>> > + # This receives the filtered author (but that is better than an Xml fail)
>> > + expected_author = 'foobar'
>> > + else:
>> > + expected_author = 'foo\bbar'
>> > +
>> > + expected_output = svntest.verify.UnorderedOutput([
>> > + ' 1 %-8s Jan 01 2000 ./\n' % expected_author,
>> > + ' 1 %-8s Jan 01 2000 A/\n' % expected_author,
>> > + ' 1 %-8s 25 Jan 01 2000 iota\n' % expected_author
>> > + ])
>> Hi Bert,
>>
>> This test is failing on system with non-US default locale, because
>> 'svn ls -v' prints date in locale depended format.
>
> I run my system with Dutch date formats but still see the US format when running the tests (because we force a locale somewhere), while a normal invocation of 'svn -v' does show it in a different format.
> (In my case 'Jan' would just be 'jan' (different capitalization))
>
> Are you sure that there isn't a different problem here?
>
> The test can probably be tweaked to use some kind of regex matching, but I doubt whether that is necessary.
>
There are several settings in Windows that affect locale used for
applications. Do you have configured "Language for non-Unicode
programs" to Dutch on your system?
--
Ivan Zhakov
RE: svn commit: r1654810 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: Ivan Zhakov [mailto:ivan@visualsvn.com]
> Sent: maandag 9 februari 2015 13:16
> To: Subversion Development
> Cc: Bert Huijben
> Subject: Re: svn commit: r1654810 -
> /subversion/trunk/subversion/tests/cmdline/prop_tests.py
>
> On 26 January 2015 at 17:17, <rh...@apache.org> wrote:
> > Author: rhuijben
> > Date: Mon Jan 26 14:17:25 2015
> > New Revision: 1654810
> >
> > URL: http://svn.apache.org/r1654810
> > Log:
> > Following up on r1654794, add a related test that verifies the author value
> > retrieved with the stat ra functions.
> >
> > * subversion/tests/cmdline/prop_tests.py
> > (xml_unsafe_author2): New test.
> > (test_list): Add xml_unsafe_author2.
> >
> > Modified:
> > subversion/trunk/subversion/tests/cmdline/prop_tests.py
> >
> > Modified: subversion/trunk/subversion/tests/cmdline/prop_tests.py
> > URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/prop_
> tests.py?rev=1654810&r1=1654809&r2=1654810&view=diff
> >
> ================================================================
> ==============
> > --- subversion/trunk/subversion/tests/cmdline/prop_tests.py (original)
> > +++ subversion/trunk/subversion/tests/cmdline/prop_tests.py Mon Jan 26
> 14:17:25 2015
> > @@ -2669,6 +2669,46 @@ def xml_unsafe_author(sbox):
> > 'proplist', '--revprop', '-r', '1', '-v',
> > wc_dir)
> >
> > +@Issue(4415)
> > +def xml_unsafe_author2(sbox):
> > + "svn:author with XML unsafe chars 2"
> > +
> > + sbox.build(create_wc = False)
> > + repo_url = sbox.repo_url
> > +
> > + svntest.actions.enable_revprop_changes(sbox.repo_dir)
> > +
> > + # client sends svn:author (via PROPPATCH for DAV)
> > + svntest.actions.run_and_verify_svn(None, None, [],
> > + 'propset', '--revprop', '-r', '1',
> > + 'svn:author', 'foo\bbar', repo_url)
> > +
> > + # Ensure a stable date
> > + svntest.actions.run_and_verify_svn(None, None, [],
> > + 'propset', '--revprop', '-r', '1',
> > + 'svn:date', '2000-01-01T12:00:00.0Z',
> > + repo_url)
> > +
> > + if svntest.main.is_ra_type_dav():
> > + # This receives the filtered author (but that is better than an Xml fail)
> > + expected_author = 'foobar'
> > + else:
> > + expected_author = 'foo\bbar'
> > +
> > + expected_output = svntest.verify.UnorderedOutput([
> > + ' 1 %-8s Jan 01 2000 ./\n' % expected_author,
> > + ' 1 %-8s Jan 01 2000 A/\n' % expected_author,
> > + ' 1 %-8s 25 Jan 01 2000 iota\n' % expected_author
> > + ])
> Hi Bert,
>
> This test is failing on system with non-US default locale, because
> 'svn ls -v' prints date in locale depended format.
I run my system with Dutch date formats but still see the US format when running the tests (because we force a locale somewhere), while a normal invocation of 'svn -v' does show it in a different format.
(In my case 'Jan' would just be 'jan' (different capitalization))
Are you sure that there isn't a different problem here?
The test can probably be tweaked to use some kind of regex matching, but I doubt whether that is necessary.
Bert