You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by pa...@apache.org on 2023/05/11 02:35:05 UTC
[shardingsphere] branch master updated: Use primitive boolean in MySQLTextResultSetRowPacket (#25566)
This is an automated email from the ASF dual-hosted git repository.
panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 3d21f3fbf19 Use primitive boolean in MySQLTextResultSetRowPacket (#25566)
3d21f3fbf19 is described below
commit 3d21f3fbf19d9e8afc80aa1a4a21bcae5f6c3205
Author: 吴伟杰 <wu...@apache.org>
AuthorDate: Thu May 11 10:34:56 2023 +0800
Use primitive boolean in MySQLTextResultSetRowPacket (#25566)
---
.../mysql/packet/command/query/text/MySQLTextResultSetRowPacket.java | 2 +-
.../packet/command/query/text/MySQLTextResultSetRowPacketTest.java | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/db-protocol/mysql/src/main/java/org/apache/shardingsphere/db/protocol/mysql/packet/command/query/text/MySQLTextResultSetRowPacket.java b/db-protocol/mysql/src/main/java/org/apache/shardingsphere/db/protocol/mysql/packet/command/query/text/MySQLTextResultSetRowPacket.java
index ce959432210..148a181c35f 100644
--- a/db-protocol/mysql/src/main/java/org/apache/shardingsphere/db/protocol/mysql/packet/command/query/text/MySQLTextResultSetRowPacket.java
+++ b/db-protocol/mysql/src/main/java/org/apache/shardingsphere/db/protocol/mysql/packet/command/query/text/MySQLTextResultSetRowPacket.java
@@ -70,7 +70,7 @@ public final class MySQLTextResultSetRowPacket implements MySQLPacket {
} else if (data instanceof BigDecimal) {
payload.writeStringLenenc(((BigDecimal) data).toPlainString());
} else if (data instanceof Boolean) {
- payload.writeBytesLenenc((Boolean) data ? new byte[]{1} : new byte[]{0});
+ payload.writeBytesLenenc((boolean) data ? new byte[]{1} : new byte[]{0});
} else if (data instanceof LocalDateTime) {
payload.writeStringLenenc(DATE_TIME_FORMATTER.format((LocalDateTime) data));
} else {
diff --git a/db-protocol/mysql/src/test/java/org/apache/shardingsphere/db/protocol/mysql/packet/command/query/text/MySQLTextResultSetRowPacketTest.java b/db-protocol/mysql/src/test/java/org/apache/shardingsphere/db/protocol/mysql/packet/command/query/text/MySQLTextResultSetRowPacketTest.java
index 9e9ae9da4bd..d6e3534e9f5 100644
--- a/db-protocol/mysql/src/test/java/org/apache/shardingsphere/db/protocol/mysql/packet/command/query/text/MySQLTextResultSetRowPacketTest.java
+++ b/db-protocol/mysql/src/test/java/org/apache/shardingsphere/db/protocol/mysql/packet/command/query/text/MySQLTextResultSetRowPacketTest.java
@@ -51,7 +51,7 @@ class MySQLTextResultSetRowPacketTest {
void assertWrite() {
long now = System.currentTimeMillis();
Timestamp timestamp = new Timestamp(now);
- MySQLTextResultSetRowPacket actual = new MySQLTextResultSetRowPacket(Arrays.asList(null, "value", BigDecimal.ONE, new byte[]{}, timestamp));
+ MySQLTextResultSetRowPacket actual = new MySQLTextResultSetRowPacket(Arrays.asList(null, "value", BigDecimal.ONE, new byte[]{}, timestamp, Boolean.TRUE));
actual.write(payload);
verify(payload).writeInt1(0xfb);
verify(payload).writeStringLenenc("value");
@@ -61,6 +61,7 @@ class MySQLTextResultSetRowPacketTest {
} else {
verify(payload).writeStringLenenc(timestamp.toString());
}
+ verify(payload).writeBytesLenenc(new byte[]{1});
}
@Test