You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Marshall <tw...@gmail.com> on 2012/06/20 23:57:14 UTC
Review Request: Libprocess-ify Allocator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5451/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Description
-------
Factored allocator out into its own libprocess prcoess.
This patch depends on another pending code review "Changed SimpleAllocator to DominantShareAllocator"
Diffs
-----
include/mesos/mesos.proto 31e1343
src/common/hashmap.hpp 50a1b74
src/master/allocator.hpp 0fc61a5
src/master/constants.hpp c3b0b25
src/master/dominant_share_allocator.hpp PRE-CREATION
src/master/dominant_share_allocator.cpp PRE-CREATION
src/master/http.cpp a4cc19d
src/master/master.hpp 886f79c
src/master/master.cpp 89cdaf6
src/slave/slave.cpp aac11e0
src/tests/resource_offers_tests.cpp c1f1760
src/tests/utils.hpp e81ec82
Diff: https://reviews.apache.org/r/5451/diff/
Testing
-------
make check on Lion
Thanks,
Thomas Marshall
Re: Review Request: Libprocess-ify Allocator
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5451/
-----------------------------------------------------------
(Updated June 27, 2012, 7:53 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Reflects the fact that it is not possible for resourcesUnused to be called for an already removed framework, since if you try to allocate resources to a removed framework, the master will dispatch a resourcesRecovered call.
Description
-------
Factored allocator out into its own libprocess prcoess.
This patch depends on another pending code review "Changed SimpleAllocator to DominantShareAllocator"
This addresses bug MESOS-223.
https://issues.apache.org/jira/browse/MESOS-223
Diffs (updated)
-----
include/mesos/mesos.proto 31e1343
src/common/hashmap.hpp 50a1b74
src/master/allocator.hpp 0fc61a5
src/master/constants.hpp c3b0b25
src/master/dominant_share_allocator.hpp PRE-CREATION
src/master/dominant_share_allocator.cpp PRE-CREATION
src/master/http.cpp a4cc19d
src/master/master.hpp 886f79c
src/master/master.cpp 89cdaf6
src/slave/slave.cpp aac11e0
src/tests/resource_offers_tests.cpp c1f1760
src/tests/utils.hpp e81ec82
Diff: https://reviews.apache.org/r/5451/diff/
Testing
-------
make check on Lion
Thanks,
Thomas Marshall
Re: Review Request: Libprocess-ify Allocator
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5451/
-----------------------------------------------------------
(Updated June 26, 2012, 7:09 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
I created a Jira issue to track progress on the allocator work.
Description
-------
Factored allocator out into its own libprocess prcoess.
This patch depends on another pending code review "Changed SimpleAllocator to DominantShareAllocator"
This addresses bug MESOS-223.
https://issues.apache.org/jira/browse/MESOS-223
Diffs
-----
include/mesos/mesos.proto 31e1343
src/common/hashmap.hpp 50a1b74
src/master/allocator.hpp 0fc61a5
src/master/constants.hpp c3b0b25
src/master/dominant_share_allocator.hpp PRE-CREATION
src/master/dominant_share_allocator.cpp PRE-CREATION
src/master/http.cpp a4cc19d
src/master/master.hpp 886f79c
src/master/master.cpp 89cdaf6
src/slave/slave.cpp aac11e0
src/tests/resource_offers_tests.cpp c1f1760
src/tests/utils.hpp e81ec82
Diff: https://reviews.apache.org/r/5451/diff/
Testing
-------
make check on Lion
Thanks,
Thomas Marshall
Re: Review Request: Libprocess-ify Allocator
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5451/#review8548
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On June 25, 2012, 5:38 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5451/
> -----------------------------------------------------------
>
> (Updated June 25, 2012, 5:38 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> Factored allocator out into its own libprocess prcoess.
>
> This patch depends on another pending code review "Changed SimpleAllocator to DominantShareAllocator"
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 31e1343
> src/common/hashmap.hpp 50a1b74
> src/master/allocator.hpp 0fc61a5
> src/master/constants.hpp c3b0b25
> src/master/dominant_share_allocator.hpp PRE-CREATION
> src/master/dominant_share_allocator.cpp PRE-CREATION
> src/master/http.cpp a4cc19d
> src/master/master.hpp 886f79c
> src/master/master.cpp 89cdaf6
> src/slave/slave.cpp aac11e0
> src/tests/resource_offers_tests.cpp c1f1760
> src/tests/utils.hpp e81ec82
>
> Diff: https://reviews.apache.org/r/5451/diff/
>
>
> Testing
> -------
>
> make check on Lion
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request: Libprocess-ify Allocator
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5451/
-----------------------------------------------------------
(Updated June 25, 2012, 5:38 p.m.)
Review request for mesos and Benjamin Hindman.
Description
-------
Factored allocator out into its own libprocess prcoess.
This patch depends on another pending code review "Changed SimpleAllocator to DominantShareAllocator"
Diffs
-----
include/mesos/mesos.proto 31e1343
src/common/hashmap.hpp 50a1b74
src/master/allocator.hpp 0fc61a5
src/master/constants.hpp c3b0b25
src/master/dominant_share_allocator.hpp PRE-CREATION
src/master/dominant_share_allocator.cpp PRE-CREATION
src/master/http.cpp a4cc19d
src/master/master.hpp 886f79c
src/master/master.cpp 89cdaf6
src/slave/slave.cpp aac11e0
src/tests/resource_offers_tests.cpp c1f1760
src/tests/utils.hpp e81ec82
Diff: https://reviews.apache.org/r/5451/diff/
Testing
-------
make check on Lion
Thanks,
Thomas Marshall