You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "4yDX3906 (via GitHub)" <gi...@apache.org> on 2023/02/28 16:05:02 UTC
[GitHub] [skywalking] 4yDX3906 opened a new pull request, #10466: fix:Utility classes should not have public constructors
4yDX3906 opened a new pull request, #10466:
URL: https://github.com/apache/skywalking/pull/10466
Utility classes, which are collections of static members, are not meant to be instantiated. Even abstract utility classes, which can be extended, should not have public constructors.
Java adds an implicit public constructor to every class which does not define at least one explicitly. Hence, at least one non-public constructor should be defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10466: fix:Utility classes should not have public constructors
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10466:
URL: https://github.com/apache/skywalking/pull/10466#issuecomment-1448476344
These code style things seem not having meaning in practice.
We don't want to be strict for this after all.
We intend to resolve real problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed pull request #10466: fix:Utility classes should not have public constructors
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed pull request #10466: fix:Utility classes should not have public constructors
URL: https://github.com/apache/skywalking/pull/10466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org