You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Martijn van Groningen (JIRA)" <ji...@apache.org> on 2009/12/21 21:25:18 UTC
[jira] Created: (SOLR-1680) Fieldcollapse related changes to the
core
Fieldcollapse related changes to the core
-----------------------------------------
Key: SOLR-1680
URL: https://issues.apache.org/jira/browse/SOLR-1680
Project: Solr
Issue Type: Sub-task
Components: search
Affects Versions: 1.3
Reporter: Martijn van Groningen
Fix For: 1.5
Child issue of SOLR-236. The issue is dedicated to incorporate fieldcollapse's changes to the Solr's core code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1680) Provide an API to specify custom
Collectors
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797666#action_12797666 ]
Grant Ingersoll commented on SOLR-1680:
---------------------------------------
Why not broaden this and allow people to pass in their own collectors?
Also, can you explain a bit more the use case specifically for Field Collapse?
Alternatively, given something like LUCENE-2127, we may want Solr to be able to make query time decisions about what Collector to use.
> Provide an API to specify custom Collectors
> -------------------------------------------
>
> Key: SOLR-1680
> URL: https://issues.apache.org/jira/browse/SOLR-1680
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Affects Versions: 1.3
> Reporter: Martijn van Groningen
> Fix For: 1.5
>
> Attachments: field-collapse-core.patch, SOLR-1680.patch
>
>
> The issue is dedicated to incorporate fieldcollapse's changes to the Solr's core code.
> We want to make it possible for components to specify custom Collectors in SolrIndexSearcher methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1680) Provide an API to specify custom
Collectors
Posted by "patrick o'leary (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797774#action_12797774 ]
patrick o'leary commented on SOLR-1680:
---------------------------------------
We've just done something like this recently and found the simplest was was to modify
ResponseBuilder with setCustomCollector / getCustomCollector,
update the QueryCommand to include the custom collector.
It gets sticky in the SolrIndexSearcher with caching, and IIRC about 4 places to call the collector, the solution works, but is not in anyway elegant.
It would be good to see if we could refactor SolrIndexSearcher first to make it more streamlined.
> Provide an API to specify custom Collectors
> -------------------------------------------
>
> Key: SOLR-1680
> URL: https://issues.apache.org/jira/browse/SOLR-1680
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Affects Versions: 1.3
> Reporter: Martijn van Groningen
> Fix For: 1.5
>
> Attachments: field-collapse-core.patch, SOLR-1680.patch
>
>
> The issue is dedicated to incorporate fieldcollapse's changes to the Solr's core code.
> We want to make it possible for components to specify custom Collectors in SolrIndexSearcher methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1680) Provide an API to specify custom
Collectors
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794332#action_12794332 ]
Noble Paul commented on SOLR-1680:
----------------------------------
the class org.apache.solr.util.DocSetScoreCollector is missing in this patch
> Provide an API to specify custom Collectors
> -------------------------------------------
>
> Key: SOLR-1680
> URL: https://issues.apache.org/jira/browse/SOLR-1680
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Affects Versions: 1.3
> Reporter: Martijn van Groningen
> Fix For: 1.5
>
> Attachments: field-collapse-core.patch
>
>
> The issue is dedicated to incorporate fieldcollapse's changes to the Solr's core code.
> We want to make it possible for components to specify custom Collectors in SolrIndexSearcher methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1680) Fieldcollapse related changes to the
core
Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn van Groningen updated SOLR-1680:
----------------------------------------
Attachment: field-collapse-core.patch
This patch contains changes to Solr's core from the last attached patch.
> Fieldcollapse related changes to the core
> -----------------------------------------
>
> Key: SOLR-1680
> URL: https://issues.apache.org/jira/browse/SOLR-1680
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Affects Versions: 1.3
> Reporter: Martijn van Groningen
> Fix For: 1.5
>
> Attachments: field-collapse-core.patch
>
>
> Child issue of SOLR-236. The issue is dedicated to incorporate fieldcollapse's changes to the Solr's core code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1680) Provide an API to specify custom
Collectors
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797771#action_12797771 ]
Shalin Shekhar Mangar commented on SOLR-1680:
---------------------------------------------
bq. Why not broaden this and allow people to pass in their own collectors?
Yes, that is the general idea, though it would be API driven than configuration. Any component should be able to pass a Collector to the various SolrIndexSearcher methods.
bq. Also, can you explain a bit more the use case specifically for Field Collapse?
Field Collapsing needs to use a custom collector. Right now the collector is hard coded inside SolrIndexSearcher.
bq. Alternatively, given something like LUCENE-2127, we may want Solr to be able to make query time decisions about what Collector to use.
I guess that decision should be made by QueryComponent? If so, then the ability to pass a custom Collector to SolrIndexSearcher methods should be enough.
> Provide an API to specify custom Collectors
> -------------------------------------------
>
> Key: SOLR-1680
> URL: https://issues.apache.org/jira/browse/SOLR-1680
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Affects Versions: 1.3
> Reporter: Martijn van Groningen
> Fix For: 1.5
>
> Attachments: field-collapse-core.patch, SOLR-1680.patch
>
>
> The issue is dedicated to incorporate fieldcollapse's changes to the Solr's core code.
> We want to make it possible for components to specify custom Collectors in SolrIndexSearcher methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1680) Provide an API to specify custom
Collectors
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-1680:
-----------------------------
Attachment: SOLR-1680.patch
I have added the class DocSetScoreCollector to the previous patch.
> Provide an API to specify custom Collectors
> -------------------------------------------
>
> Key: SOLR-1680
> URL: https://issues.apache.org/jira/browse/SOLR-1680
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Affects Versions: 1.3
> Reporter: Martijn van Groningen
> Fix For: 1.5
>
> Attachments: field-collapse-core.patch, SOLR-1680.patch
>
>
> The issue is dedicated to incorporate fieldcollapse's changes to the Solr's core code.
> We want to make it possible for components to specify custom Collectors in SolrIndexSearcher methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1680) Provide an API to specify custom
Collectors
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar updated SOLR-1680:
----------------------------------------
Description:
The issue is dedicated to incorporate fieldcollapse's changes to the Solr's core code.
We want to make it possible for components to specify custom Collectors in SolrIndexSearcher methods.
was:Child issue of SOLR-236. The issue is dedicated to incorporate fieldcollapse's changes to the Solr's core code.
Summary: Provide an API to specify custom Collectors (was: Fieldcollapse related changes to the core)
> Provide an API to specify custom Collectors
> -------------------------------------------
>
> Key: SOLR-1680
> URL: https://issues.apache.org/jira/browse/SOLR-1680
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Affects Versions: 1.3
> Reporter: Martijn van Groningen
> Fix For: 1.5
>
> Attachments: field-collapse-core.patch
>
>
> The issue is dedicated to incorporate fieldcollapse's changes to the Solr's core code.
> We want to make it possible for components to specify custom Collectors in SolrIndexSearcher methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.