You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Boglarka Egyed <eg...@gmail.com> on 2016/05/24 00:24:46 UTC
Review Request 47750: SQOOP-2867
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47750/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2867
https://issues.apache.org/jira/browse/SQOOP-2867
Repository: sqoop-sqoop2
Description
-------
Sqoop2: ResTiliency: Define one single constant for all
Diffs
-----
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java 1556e34
client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 5394493
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java bf674df
client/src/main/java/org/apache/sqoop/client/request/RequestConstants.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java 8d4d72b
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c760689
server/src/main/java/org/apache/sqoop/handler/HandlerConstants.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java c86f8f0
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b44ae87
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 06c4478
Diff: https://reviews.apache.org/r/47750/diff/
Testing
-------
Run integration tests.
Thanks,
Boglarka Egyed
Re: Review Request 47750: SQOOP-2867
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47750/#review134507
-----------------------------------------------------------
it looks like "all" is used by the client and the server. Perhaps we can move the constant to a shared library (sqoop-common)?
- Abraham Fine
On May 24, 2016, 12:24 a.m., Boglarka Egyed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47750/
> -----------------------------------------------------------
>
> (Updated May 24, 2016, 12:24 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2867
> https://issues.apache.org/jira/browse/SQOOP-2867
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Sqoop2: ResTiliency: Define one single constant for all
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java 1556e34
> client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 5394493
> client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java bf674df
> client/src/main/java/org/apache/sqoop/client/request/RequestConstants.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java 8d4d72b
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c760689
> server/src/main/java/org/apache/sqoop/handler/HandlerConstants.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java c86f8f0
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b44ae87
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 06c4478
>
> Diff: https://reviews.apache.org/r/47750/diff/
>
>
> Testing
> -------
>
> Run integration tests.
>
>
> Thanks,
>
> Boglarka Egyed
>
>
Re: Review Request 47750: SQOOP-2867
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47750/#review134652
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Fine
On May 24, 2016, 10:42 p.m., Boglarka Egyed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47750/
> -----------------------------------------------------------
>
> (Updated May 24, 2016, 10:42 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2867
> https://issues.apache.org/jira/browse/SQOOP-2867
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Sqoop2: ResTiliency: Define one single constant for all
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java 1556e34
> client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 5394493
> client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java bf674df
> common/src/main/java/org/apache/sqoop/common/SqoopProtocolConstants.java 29927c0
> server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java 8d4d72b
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c760689
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java c86f8f0
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b44ae87
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 06c4478
>
> Diff: https://reviews.apache.org/r/47750/diff/
>
>
> Testing
> -------
>
> Run integration tests.
>
>
> Thanks,
>
> Boglarka Egyed
>
>
Re: Review Request 47750: SQOOP-2867
Posted by Boglarka Egyed <eg...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47750/
-----------------------------------------------------------
(Updated May 24, 2016, 10:42 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2867
https://issues.apache.org/jira/browse/SQOOP-2867
Repository: sqoop-sqoop2
Description
-------
Sqoop2: ResTiliency: Define one single constant for all
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java 1556e34
client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 5394493
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java bf674df
common/src/main/java/org/apache/sqoop/common/SqoopProtocolConstants.java 29927c0
server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java 8d4d72b
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c760689
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java c86f8f0
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b44ae87
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 06c4478
Diff: https://reviews.apache.org/r/47750/diff/
Testing
-------
Run integration tests.
Thanks,
Boglarka Egyed