You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ch...@apache.org on 2024/12/29 11:06:20 UTC
(kafka) branch 4.0 updated: KAFKA-18314 Fix to Kraft or remove tests associate with Zk Broker config in KafkaApisTest (#18309)
This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/4.0 by this push:
new 0864f8155a5 KAFKA-18314 Fix to Kraft or remove tests associate with Zk Broker config in KafkaApisTest (#18309)
0864f8155a5 is described below
commit 0864f8155a5214bc7bbd955ad456f664b709c77a
Author: TengYao Chi <ki...@gmail.com>
AuthorDate: Sun Dec 29 19:02:27 2024 +0800
KAFKA-18314 Fix to Kraft or remove tests associate with Zk Broker config in KafkaApisTest (#18309)
Reviewers: TaiJuWu <tj...@gmail.com>, Chia-Ping Tsai <ch...@gmail.com>
---
.../scala/unit/kafka/server/KafkaApisTest.scala | 53 +---------------------
1 file changed, 1 insertion(+), 52 deletions(-)
diff --git a/core/src/test/scala/unit/kafka/server/KafkaApisTest.scala b/core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
index 92935a887cf..02e793b4dc0 100644
--- a/core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
+++ b/core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
@@ -173,12 +173,11 @@ class KafkaApisTest extends Logging {
overrideProperties: Map[String, String] = Map.empty,
featureVersions: Seq[FeatureVersion] = Seq.empty): KafkaApis = {
val properties = if (raftSupport) {
- val properties = TestUtils.createBrokerConfig(brokerId, "")
+ val properties = TestUtils.createBrokerConfig(brokerId, null)
properties.put(KRaftConfigs.NODE_ID_CONFIG, brokerId.toString)
properties.put(KRaftConfigs.PROCESS_ROLES_CONFIG, "broker")
val voterId = brokerId + 1
properties.put(QuorumConfig.QUORUM_VOTERS_CONFIG, s"$voterId@localhost:9093")
- properties.put(KRaftConfigs.CONTROLLER_LISTENER_NAMES_CONFIG, "SSL")
properties
} else {
TestUtils.createBrokerConfig(brokerId, "zk")
@@ -739,22 +738,6 @@ class KafkaApisTest extends Logging {
assertEquals(cmConfigs.size, configs.size)
}
- @Test
- def testDescribeQuorumNotAllowedForZkClusters(): Unit = {
- val requestData = DescribeQuorumRequest.singletonRequest(KafkaRaftServer.MetadataPartition)
- val requestBuilder = new DescribeQuorumRequest.Builder(requestData)
- val request = buildRequest(requestBuilder.build(DescribeQuorumRequestData.HIGHEST_SUPPORTED_VERSION))
-
- when(clientRequestQuotaManager.maybeRecordAndGetThrottleTimeMs(any[RequestChannel.Request](),
- any[Long])).thenReturn(0)
- kafkaApis = createKafkaApis(enableForwarding = true)
- kafkaApis.handle(request, RequestLocal.withThreadConfinedCaching)
-
- val response = verifyNoThrottling[DescribeQuorumResponse](request)
- assertEquals(Errors.UNKNOWN_SERVER_ERROR, Errors.forCode(response.data.errorCode))
- assertEquals(Errors.UNKNOWN_SERVER_ERROR.message(), response.data.errorMessage)
- }
-
@Test
def testDescribeQuorumForwardedForKRaftClusters(): Unit = {
val requestData = DescribeQuorumRequest.singletonRequest(KafkaRaftServer.MetadataPartition)
@@ -11426,18 +11409,6 @@ class KafkaApisTest extends Logging {
assertEquals(Errors.FENCED_MEMBER_EPOCH.code, response.data.groups.get(0).errorCode)
}
- @Test
- def testGetTelemetrySubscriptionsNotAllowedForZkClusters(): Unit = {
- val data = new GetTelemetrySubscriptionsRequestData()
-
- val request = buildRequest(new GetTelemetrySubscriptionsRequest.Builder(data, true).build())
- kafkaApis = createKafkaApis(enableForwarding = true)
- kafkaApis.handle(request, RequestLocal.noCaching)
-
- val response = verifyNoThrottling[GetTelemetrySubscriptionsResponse](request)
- assertEquals(Errors.UNKNOWN_SERVER_ERROR, Errors.forCode(response.data.errorCode))
- }
-
@Test
def testGetTelemetrySubscriptions(): Unit = {
val request = buildRequest(new GetTelemetrySubscriptionsRequest.Builder(
@@ -11477,18 +11448,6 @@ class KafkaApisTest extends Logging {
assertEquals(expectedResponse, response.data)
}
- @Test
- def testPushTelemetryNotAllowedForZkClusters(): Unit = {
- val data = new PushTelemetryRequestData()
-
- val request = buildRequest(new PushTelemetryRequest.Builder(data, true).build())
- kafkaApis = createKafkaApis(enableForwarding = true)
- kafkaApis.handle(request, RequestLocal.noCaching)
-
- val response = verifyNoThrottling[PushTelemetryResponse](request)
- assertEquals(Errors.UNKNOWN_SERVER_ERROR, Errors.forCode(response.data.errorCode))
- }
-
@Test
def testPushTelemetry(): Unit = {
val request = buildRequest(new PushTelemetryRequest.Builder(new PushTelemetryRequestData(), true).build())
@@ -11523,16 +11482,6 @@ class KafkaApisTest extends Logging {
assertEquals(expectedResponse, response.data)
}
- @Test
- def testListClientMetricsResourcesNotAllowedForZkClusters(): Unit = {
- val request = buildRequest(new ListClientMetricsResourcesRequest.Builder(new ListClientMetricsResourcesRequestData()).build())
- kafkaApis = createKafkaApis(enableForwarding = true)
- kafkaApis.handle(request, RequestLocal.noCaching)
-
- val response = verifyNoThrottling[ListClientMetricsResourcesResponse](request)
- assertEquals(Errors.UNKNOWN_SERVER_ERROR, Errors.forCode(response.data.errorCode))
- }
-
@Test
def testListClientMetricsResources(): Unit = {
val request = buildRequest(new ListClientMetricsResourcesRequest.Builder(new ListClientMetricsResourcesRequestData()).build())