[jira] [Commented] (GEODE-8246) Enforce No Shadow as Error

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133864#comment-17133864 ] 

ASF GitHub Bot commented on GEODE-8246:
---------------------------------------

moleske opened a new pull request #618:
URL: https://github.com/apache/geode-native/pull/618


   There's a lot of files that were touched.  If folks have ideas on how to break it up such that it is easier to review let me know.  I basically took the approach of remove it from CMakeLists.txt, then go fix all the errors (with occasional aggressive rename).  Most of the no shadow errors were from the older testing suite.  Tests run and passing on Kubuntu 20.04, Mac Catalina, and Windows 10.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Enforce No Shadow as Error
> --------------------------
>
>                 Key: GEODE-8246
>                 URL: https://issues.apache.org/jira/browse/GEODE-8246
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Michael Oleske
>            Priority: Major
>
> Given I compile the code without exempting no-shadow
> Then it should compile
> Note - was marked as a todo



--
This message was sent by Atlassian Jira
(v8.3.4#803005)