[jira] [Commented] (HDFS-5723) Append failed FINALIZED replica should not be accepted as valid when that block is underconstruction

["stanley shi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019738#comment-14019738 ] 

stanley shi commented on HDFS-5723:
-----------------------------------

Hi Vinay, there're still some bug with this patch;

I just tested this patch in my environment, here's the steps:
environment: HA cluster with 4 datanodes;
1. put one file (one block) to hdfs with repl=3;
2. use "fsck" to check which datanode has the blocks; and also which datanode don't have it (the "free node")
3. close the first datanode that has the block(first one shown in the fsck command);
4. append content to the file 100 times;
5. close the "free node" and restart the "first datanode"
6. append content to the file 100 times again;

check the datanodes, this error message still occurs;

> Append failed FINALIZED replica should not be accepted as valid when that block is underconstruction
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5723
>                 URL: https://issues.apache.org/jira/browse/HDFS-5723
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.2.0
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-5723.patch, HDFS-5723.patch
>
>
> Scenario:
> 1. 3 node cluster with dfs.client.block.write.replace-datanode-on-failure.enable set to false.
> 2. One file is written with 3 replicas, blk_id_gs1
> 3. One of the datanode DN1 is down.
> 4. File was opened with append and some more data is added to the file and synced. (to only 2 live nodes DN2 and DN3)-- blk_id_gs2
> 5. Now  DN1 restarted
> 6. In this block report, DN1 reported FINALIZED block blk_id_gs1, this should be marked corrupted.
> but since NN having appended block state as UnderConstruction, at this time its not detecting this block as corrupt and adding to valid block locations.
> As long as the namenode is alive, this datanode also will be considered as valid replica and read/append will fail in that datanode.



--
This message was sent by Atlassian JIRA
(v6.2#6252)