You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/07/19 20:40:59 UTC
[jira] [Created] (HDFS-2168) 1073: Reenable
TestEditLog.testFailedOpen and fix exposed bug
1073: Reenable TestEditLog.testFailedOpen and fix exposed bug
-------------------------------------------------------------
Key: HDFS-2168
URL: https://issues.apache.org/jira/browse/HDFS-2168
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Todd Lipcon
Assignee: Todd Lipcon
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2168) 1073: Reenable
TestEditLog.testFailedOpen and fix exposed bug
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-2168:
------------------------------
Attachment: hdfs-2168.txt
Fairly straightforward patch. Rather than using mockito for the test, I just muck with permissions to cause the edits log to fail to open.
> 1073: Reenable TestEditLog.testFailedOpen and fix exposed bug
> -------------------------------------------------------------
>
> Key: HDFS-2168
> URL: https://issues.apache.org/jira/browse/HDFS-2168
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
> Attachments: hdfs-2168.txt
>
>
> As Jitendra noticed in reviewing HDFS-1073, this test case was accidentally left disabled in the branch. Re-enabling it and modifying it to work with the new code exposed that HDFS-1952 hadn't been merged fully into the branch. This JIRA is to re-enable that test and fix the bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2168) 1073: Reenable
TestEditLog.testFailedOpen and fix exposed bug
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068049#comment-13068049 ]
Todd Lipcon commented on HDFS-2168:
-----------------------------------
Will fix the period on commit. as for count vs num, looks like countBlah() shows up in 7 function calls in HDFS whereas numBlah() only shows up in 4.
(ack -h -o '\b(num|count)[A-Z][a-zA-Z]+\(' hdfs/src/java/ | sort | uniq). So sticking with count for consistency.
> 1073: Reenable TestEditLog.testFailedOpen and fix exposed bug
> -------------------------------------------------------------
>
> Key: HDFS-2168
> URL: https://issues.apache.org/jira/browse/HDFS-2168
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
> Attachments: hdfs-2168.txt
>
>
> As Jitendra noticed in reviewing HDFS-1073, this test case was accidentally left disabled in the branch. Re-enabling it and modifying it to work with the new code exposed that HDFS-1952 hadn't been merged fully into the branch. This JIRA is to re-enable that test and fix the bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2168) 1073: Reenable
TestEditLog.testFailedOpen and fix exposed bug
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-2168:
------------------------------
Component/s: name-node
Description: As Jitendra noticed in reviewing HDFS-1073, this test case was accidentally left disabled in the branch. Re-enabling it and modifying it to work with the new code exposed that HDFS-1952 hadn't been merged fully into the branch. This JIRA is to re-enable that test and fix the bug.
Affects Version/s: Edit log branch (HDFS-1073)
Fix Version/s: Edit log branch (HDFS-1073)
> 1073: Reenable TestEditLog.testFailedOpen and fix exposed bug
> -------------------------------------------------------------
>
> Key: HDFS-2168
> URL: https://issues.apache.org/jira/browse/HDFS-2168
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
>
> As Jitendra noticed in reviewing HDFS-1073, this test case was accidentally left disabled in the branch. Re-enabling it and modifying it to work with the new code exposed that HDFS-1952 hadn't been merged fully into the branch. This JIRA is to re-enable that test and fix the bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-2168) 1073: Reenable
TestEditLog.testFailedOpen and fix exposed bug
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved HDFS-2168.
-------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
> 1073: Reenable TestEditLog.testFailedOpen and fix exposed bug
> -------------------------------------------------------------
>
> Key: HDFS-2168
> URL: https://issues.apache.org/jira/browse/HDFS-2168
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
> Attachments: hdfs-2168.txt
>
>
> As Jitendra noticed in reviewing HDFS-1073, this test case was accidentally left disabled in the branch. Re-enabling it and modifying it to work with the new code exposed that HDFS-1952 hadn't been merged fully into the branch. This JIRA is to re-enable that test and fix the bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2168) 1073: Reenable
TestEditLog.testFailedOpen and fix exposed bug
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068026#comment-13068026 ]
Eli Collins commented on HDFS-2168:
-----------------------------------
+1
Nit: remove the period ending the countActiveJournals javadoc. Maybe rename this method numActiveJournals?
> 1073: Reenable TestEditLog.testFailedOpen and fix exposed bug
> -------------------------------------------------------------
>
> Key: HDFS-2168
> URL: https://issues.apache.org/jira/browse/HDFS-2168
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
> Attachments: hdfs-2168.txt
>
>
> As Jitendra noticed in reviewing HDFS-1073, this test case was accidentally left disabled in the branch. Re-enabling it and modifying it to work with the new code exposed that HDFS-1952 hadn't been merged fully into the branch. This JIRA is to re-enable that test and fix the bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2168) 1073: Reenable
TestEditLog.testFailedOpen and fix exposed bug
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068460#comment-13068460 ]
Hudson commented on HDFS-2168:
------------------------------
Integrated in Hadoop-Hdfs-1073-branch #15 (See [https://builds.apache.org/job/Hadoop-Hdfs-1073-branch/15/])
HDFS-2168. Reenable TestEditLog.testFailedOpen and fix exposed bug. Contributed by Todd Lipcon.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148580
Files :
* /hadoop/common/branches/HDFS-1073/hdfs/CHANGES.HDFS-1073.txt
* /hadoop/common/branches/HDFS-1073/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
* /hadoop/common/branches/HDFS-1073/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestEditLog.java
* /hadoop/common/branches/HDFS-1073/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/BackupImage.java
> 1073: Reenable TestEditLog.testFailedOpen and fix exposed bug
> -------------------------------------------------------------
>
> Key: HDFS-2168
> URL: https://issues.apache.org/jira/browse/HDFS-2168
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
> Attachments: hdfs-2168.txt
>
>
> As Jitendra noticed in reviewing HDFS-1073, this test case was accidentally left disabled in the branch. Re-enabling it and modifying it to work with the new code exposed that HDFS-1952 hadn't been merged fully into the branch. This JIRA is to re-enable that test and fix the bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira