You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/05/21 01:14:51 UTC
[GitHub] [incubator-pinot] Jackie-Jiang opened a new issue #6955: UDF argument type matching
Jackie-Jiang opened a new issue #6955:
URL: https://github.com/apache/incubator-pinot/issues/6955
In `FunctionRegistry`, the UDFs annotated with `ScalarFunction` are registered based on the function name and the number of arguments. In addition to that, we should also allow registering multiple functions with same name and number of arguments but different argument types, and perform type matching when loading function from the registry.
E.g. `double divide(double a, double b)` and `long divide(long a, long b)`
If any of the argument is floating point type, it should pick the first one; otherwise, pick the second one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] MeihanLi commented on issue #6955: UDF argument type matching
Posted by GitBox <gi...@apache.org>.
MeihanLi commented on issue #6955:
URL: https://github.com/apache/incubator-pinot/issues/6955#issuecomment-882956977
Thanks Jackie and Siddharth for bringing it up! This support is important in our use cases, and we'd like to take up the implementation cc: @yupeng9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] MeihanLi commented on issue #6955: UDF argument type matching
Posted by GitBox <gi...@apache.org>.
MeihanLi commented on issue #6955:
URL: https://github.com/apache/incubator-pinot/issues/6955#issuecomment-882956977
Thanks Jackie and Siddharth for bringing it up! This support is important in our use cases, and we'd like to take up the implementation cc: @yupeng9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] MeihanLi commented on issue #6955: UDF argument type matching
Posted by GitBox <gi...@apache.org>.
MeihanLi commented on issue #6955:
URL: https://github.com/apache/incubator-pinot/issues/6955#issuecomment-882956977
Thanks Jackie and Siddharth for bringing it up! This support is important in our use cases, and we'd like to take up the implementation cc: @yupeng9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on issue #6955: UDF argument type matching
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on issue #6955:
URL: https://github.com/apache/incubator-pinot/issues/6955#issuecomment-845622500
+1
When this came up in our offline discussions with you and @amrishlal , we had discussed compile time code generation of java classes using templates as opposed to manually hand writing each combination of a function. There could be other approaches too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org