You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2015/05/12 17:29:56 UTC

[GitHub] flink pull request: [FLINK-1885] [gelly] Added bulk execution mode...

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/598#issuecomment-101321028
  
    I had a look at this, and it actually looks quite good. The basic idea seems to be that you emit the original vertex if no update happens.
    
    It would be nice to not have the `isLastCollected` flag in the user-facing classes. If you could have a dedicated vertex-centric bulk coGroup, with its own output collector, you can track this in the OutputCollector. I think that would be cleanrer with respect to the user-facing API.
    
    Otherwise, I think this is a good addition...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---