[GitHub] [beam] kmjung commented on a change in pull request #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size

[GitBox <gi...@apache.org>]

kmjung commented on a change in pull request #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size
URL: https://github.com/apache/beam/pull/11292#discussion_r404996088
 
 

 ##########
 File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServices.java
 ##########
 @@ -101,10 +101,6 @@ JobStatistics dryRunQuery(String projectId, JobConfigurationQuery queryConfig, S
     @Nullable
     Table getTable(TableReference tableRef) throws InterruptedException, IOException;
 
-    @Nullable
 
 Review comment:
   BigQueryServices is a public interface, although it's meant as a private implementation for BigQuery sources and sinks and is not surfaced at the BigQueryIO level. I can restore this functionality and simply stop calling it from BigQueryStorageStreamSource.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services