You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jark Wu (Jira)" <ji...@apache.org> on 2019/11/18 12:20:00 UTC
[jira] [Commented] (FLINK-14835) Make
`org.apache.flink.configuration.Configuration` support method chaining
[ https://issues.apache.org/jira/browse/FLINK-14835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976495#comment-16976495 ]
Jark Wu commented on FLINK-14835:
---------------------------------
Personally, I'm +1 on this feature and it is backward compatible, but I'm not sure whether it will break japicmp.
> Make `org.apache.flink.configuration.Configuration` support method chaining
> ---------------------------------------------------------------------------
>
> Key: FLINK-14835
> URL: https://issues.apache.org/jira/browse/FLINK-14835
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Configuration
> Affects Versions: 1.9.1
> Reporter: Victor Wong
> Priority: Major
>
> *Goal:*
> To make the following code examples work in production, which is very handy for users to set a couple of configurations:
> {code:java}
> // instantiate table environment
> TableEnvironment tEnv = ...tEnv.getConfig() // access high-level configuration
> .getConfiguration() // set low-level key-value options
> .setString("table.exec.mini-batch.enabled", "true") // enable mini-batch optimization
> .setString("table.exec.mini-batch.allow-latency", "5 s") // use 5 seconds to buffer input records
> .setString("table.exec.mini-batch.size", "5000"); // the maximum number of records can be buffered by each aggregate operator task
> {code}
>
> *Suggestion:*
> Currently, the return type of `setXXX` method is "void", we can make it return `Configuration` itself to support method chaining.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)