[GitHub] [openwhisk-apigateway] mhamann opened a new pull request #357: Fix App ID bug, add unit tests

[GitBox <gi...@apache.org>]

mhamann opened a new pull request #357: Fix App ID bug, add unit tests
URL: https://github.com/apache/openwhisk-apigateway/pull/357
 
 
   A bug with the App ID OAuth flow was introduced as part of #353 and wasn't caught due to a missing unit test. The unit test wasn't written because it was fairly involved.
   
   Given that bug, this PR fixes the defect and adds test coverage to the function, which should ensure this doesn't occur again.
   
   Due to the need to generate JWTs and JWKs to fully test this, the [step](https://github.com/smallstep/cli) CLI is used in the test build. It appears to be [Apache 2.0 licensed](https://github.com/smallstep/cli/blob/master/LICENSE), so I assume it is safe to use? Please let me know if there are any concerns.
   
   There are a couple of minor perf improvements to the unit test Dockerfile so that build caching can occur for local testing. Thus, the `install-deps.sh` script is no longer needed (and it was only used by the tests).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services