You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/08/29 00:27:15 UTC

[GitHub] [thrift] fishy opened a new pull request #2222: THRIFT-5270: Fix wrong int to string conversions

fishy opened a new pull request #2222:
URL: https://github.com/apache/thrift/pull/2222


   Client: go
   
   Starting from go 1.15, go test starts to complain about wrongly used int
   to string conversions:
   
       ./field.go:58:83: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
       ./numeric.go:72:12: conversion from int64 to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
       ./json_protocol_test.go:612:92: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
       ./simple_json_protocol_test.go:685:96: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
   
   json_protocol_test and simple_json_protocol_test usages are actually
   already in format arg so just remove the conversion is good enough.
   field is no longer used anywhere so just removed it (there's one line of
   commented out code in compact_protocol so remove that line as well). The
   one in numeric.go is actually a bug. We didn't set sValue correctly in
   NewNumericFromI64 and NewNumericFromI32 functions.
   
   <!-- Explain the changes in the pull request below: -->
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [thrift] fishy merged pull request #2222: THRIFT-5270: Fix wrong int to string conversions

Posted by GitBox <gi...@apache.org>.
fishy merged pull request #2222:
URL: https://github.com/apache/thrift/pull/2222


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org