[jira] [Commented] (PARQUET-1177) [C++] Add more extensive compiler warnings when using Clang

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288172#comment-16288172 ] 

ASF GitHub Bot commented on PARQUET-1177:
-----------------------------------------

wesm opened a new pull request #425: PARQUET-1177: Add PARQUET_BUILD_WARNING_LEVEL option and more rigorous Clang warnings
URL: https://github.com/apache/parquet-cpp/pull/425
 
 
   These warnings will catch a number of things that have bitten us in the past, like missing virtual destructors. This brings Parquet's compiler warnings up to the same quality as Arrow's

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [C++] Add more extensive compiler warnings when using Clang
> -----------------------------------------------------------
>
>                 Key: PARQUET-1177
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1177
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-cpp
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>             Fix For: cpp-1.4.0
>
>
> We should add a "build warning level" flag like Apache Arrow, see
> https://github.com/apache/arrow/blob/master/cpp/cmake_modules/SetupCxxFlags.cmake#L73
> This will help us keep things clean



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)