You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/02/06 11:41:18 UTC

[GitHub] flink pull request #3219: [FLINK-5659] Harden FileBaseUtils#deleteFileOrDire...

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3219#discussion_r99568502
  
    --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java ---
    @@ -116,6 +118,14 @@ else if (file.exists()) {
     			}
     			catch (NoSuchFileException e) {
     				// if the file is already gone (concurrently), we don't mind
    +			} catch (AccessDeniedException e) {
    --- End diff --
    
    Is it ok to special case this inside the catch block? (I.e for windows check again, otherwise rethrow?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---