You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/11/08 10:47:57 UTC
[GitHub] jmeter pull request #323: Extracted method and used streams to improve reada...
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/323
Extracted method and used streams to improve readability
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter save_refactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/323.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #323
----
----
---
[GitHub] jmeter pull request #323: Extracted method and used streams to improve reada...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/323
---
[GitHub] jmeter issue #323: Extracted method and used streams to improve readability
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/323
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/323?src=pr&el=h1) Report
> Merging [#323](https://codecov.io/gh/apache/jmeter/pull/323?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/60def2e88b5e549f2827438b4f839545a0666372?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/jmeter/pull/323?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #323 +/- ##
===========================================
- Coverage 57.7% 57.69% -0.01%
+ Complexity 9894 9893 -1
===========================================
Files 1137 1137
Lines 72957 72957
Branches 7305 7303 -2
===========================================
- Hits 42097 42096 -1
+ Misses 28390 28389 -1
- Partials 2470 2472 +2
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/323?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [src/core/org/apache/jmeter/gui/action/Save.java](https://codecov.io/gh/apache/jmeter/pull/323?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZ3VpL2FjdGlvbi9TYXZlLmphdmE=) | `13.17% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/323?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==) | `84.61% <0%> (-0.77%)` | `17% <0%> (-1%)` | |
| [...apache/jmeter/extractor/TestBoundaryExtractor.java](https://codecov.io/gh/apache/jmeter/pull/323?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL1Rlc3RCb3VuZGFyeUV4dHJhY3Rvci5qYXZh) | `97.88% <0%> (ø)` | `17% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/323?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/323?src=pr&el=footer). Last update [60def2e...b9da250](https://codecov.io/gh/apache/jmeter/pull/323?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---