[jira] [Commented] (HADOOP-10244) TestKeyShell improperly tests the results of a Delete

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876857#comment-13876857 ] 

Hadoop QA commented on HADOOP-10244:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12624011/10244.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3448//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3448//console

This message is automatically generated.

> TestKeyShell improperly tests the results of a Delete
> -----------------------------------------------------
>
>                 Key: HADOOP-10244
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10244
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>            Reporter: Larry McCay
>            Assignee: Larry McCay
>         Attachments: 10244.patch
>
>
> The TestKeyShell.testKeySuccessfulKeyLifecycle test is supposed to ensure that the deleted key is no longer in the results of a subsequent delete command. Mistakenly, it is testing that it is STILL there.
> The delete command is actually working but the stdout capture should be reset instead of flushed. Therefore, the test is picking up the existence of the key name from the deletion message in the previous command.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)