You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/08/05 03:09:49 UTC
[GitHub] [yunikorn-k8shim] pbacsko opened a new pull request, #445: [YUNIKORN-1277] Simplify command line processing code
pbacsko opened a new pull request, #445:
URL: https://github.com/apache/yunikorn-k8shim/pull/445
### What is this PR for?
The code in `initConfigs()` uses temporary variables to hold parsed command line flags. This is not necessary, the `SchedulerConf` object can be used directly.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1277
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #445: [YUNIKORN-1277] Simplify command line processing code
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #445:
URL: https://github.com/apache/yunikorn-k8shim/pull/445#issuecomment-1206000275
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/445?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#445](https://codecov.io/gh/apache/yunikorn-k8shim/pull/445?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (10d9700) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/f676c05d3fbfb6e25e7fff2dc4766434a76456e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f676c05) will **decrease** coverage by `0.10%`.
> The diff coverage is `95.83%`.
```diff
@@ Coverage Diff @@
## master #445 +/- ##
==========================================
- Coverage 67.34% 67.24% -0.11%
==========================================
Files 41 41
Lines 6744 6728 -16
==========================================
- Hits 4542 4524 -18
- Misses 2032 2034 +2
Partials 170 170
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/conf/schedulerconf.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/445/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmYvc2NoZWR1bGVyY29uZi5nbw==) | `61.70% <95.83%> (-5.58%)` | :arrow_down: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/445/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `74.82% <0.00%> (-1.40%)` | :arrow_down: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #445: [YUNIKORN-1277] Simplify command line processing code
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #445: [YUNIKORN-1277] Simplify command line processing code
URL: https://github.com/apache/yunikorn-k8shim/pull/445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org