[GitHub] [samza] shanthoosh commented on a change in pull request #1434: SAMZA-2595: Updated MonitorService to use separate ScheduleExecutor for each monitor

[GitBox <gi...@apache.org>]

shanthoosh commented on a change in pull request #1434:
URL: https://github.com/apache/samza/pull/1434#discussion_r503570240



##########
File path: samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java
##########
@@ -100,4 +110,19 @@ public void run() {
       }
     };
   }
+
+  /**
+   * Creates a ScheduledThreadPoolExecutor with core pool size 1
+   * @return ScheduledExecutorService
+   */
+  private ScheduledExecutorService createScheduler() {

Review comment:
       Just curious.
   
   Initially we had a single threaded scheduler to ensure when two monitors in samza-admin are trying to update/modify some shared state(either on disk or in some external store), then their executions are serialized. How are we planning to achieve that goal when we allow multiple monitors to be running at the same time in their own threads.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org