You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/18 17:25:18 UTC
[GitHub] [nifi-minifi-cpp] arpadboda opened a new pull request #1008: MINIFICPP-1505 - Add SFTP build support to win built bat
arpadboda opened a new pull request #1008:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1008
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1008: MINIFICPP-1505 - Add SFTP build support to win built bat
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on a change in pull request #1008:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1008#discussion_r578985158
##########
File path: win_build_vs.bat
##########
@@ -28,6 +28,7 @@ set build_coap=OFF
set build_jni=OFF
set build_SQL=OFF
set build_AWS=OFF
+set build_SFTP=OFF
Review comment:
should we enable this in one of the windows jobs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #1008: MINIFICPP-1505 - Add SFTP build support to win built bat
Posted by GitBox <gi...@apache.org>.
arpadboda commented on a change in pull request #1008:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1008#discussion_r579045658
##########
File path: win_build_vs.bat
##########
@@ -28,6 +28,7 @@ set build_coap=OFF
set build_jni=OFF
set build_SQL=OFF
set build_AWS=OFF
+set build_SFTP=OFF
Review comment:
Two reasons I didn't do:
1) Tests require Maven and Java, so they wouldn't run with current instance configs
2) Win builds sometimes already reach timeout, didn't want to add further stuff, especially longer tests like this. (can take minutes to start up the java sftp mock server)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1008: MINIFICPP-1505 - Add SFTP build support to win built bat
Posted by GitBox <gi...@apache.org>.
adamdebreceni closed pull request #1008:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1008
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org