You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2011/12/05 22:57:11 UTC
DO NOT REPLY [Bug 52287] New: [PATCH]
fox:orphan/overwrite-content-limit ignore forced breaks
https://issues.apache.org/bugzilla/show_bug.cgi?id=52287
Bug #: 52287
Summary: [PATCH] fox:orphan/overwrite-content-limit ignore
forced breaks
Product: Fop
Version: 1.1dev
Platform: PC
Status: NEW
Severity: normal
Priority: P2
Component: page-master/layout
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: matthias8283@gmx.at
Classification: Unclassified
Created attachment 28027
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28027
Test case
When the fox:orphan/overwrite-content-limit attributes are used, forced breaks
don't work anymore.
Added breakEl.isForcedBreak() check when removing break opportunities, see
ElementListUtils.removeLegalBreaks().
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52287] [PATCH] fox:orphan/overwrite-content-limit
ignore forced breaks
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52287
Glenn Adams <gl...@skynav.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52287] [PATCH] fox:orphan/overwrite-content-limit
ignore forced breaks
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52287
--- Comment #4 from Chris Bowditch <bo...@hotmail.com> 2012-01-18 15:24:48 UTC ---
Created attachment 28168
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28168
Improved test Case with forced break
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52287] [PATCH] fox:orphan/overwrite-content-limit
ignore forced breaks
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52287
--- Comment #8 from Glenn Adams <ga...@apache.org> 2012-04-24 05:54:35 UTC ---
(In reply to comment #7)
> matthias, could you create a new patch that combines the code changes with the
> new test cases being placed into test/layoutengine/standard-testcases? i will
> then commit the patch
Matthias, I am still awaiting your input as requested above. if I see no
further input by April 30, I will close this bug due to lack of requested
information. Regards, Glenn
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52287] [PATCH] fox:orphan/overwrite-content-limit
ignore forced breaks
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52287
--- Comment #3 from Chris Bowditch <bo...@hotmail.com> 2012-01-18 15:24:22 UTC ---
Created attachment 28167
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28167
Improved Test Case with no break
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52287] [PATCH] fox:orphan/overwrite-content-limit
ignore forced breaks
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52287
--- Comment #6 from Glenn Adams <gl...@skynav.com> 2012-04-08 09:11:05 UTC ---
increase priority due to presence of a patch
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52287] [PATCH] fox:orphan/overwrite-content-limit
ignore forced breaks
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52287
Glenn Adams <gl...@skynav.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52287] [PATCH] fox:orphan/overwrite-content-limit
ignore forced breaks
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52287
--- Comment #1 from Matthias Reischenbacher <ma...@gmx.at> 2011-12-05 21:59:20 UTC ---
Created attachment 28028
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28028
Patch
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52287] [PATCH] fox:orphan/overwrite-content-limit
ignore forced breaks
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52287
--- Comment #7 from Glenn Adams <gl...@skynav.com> 2012-04-08 21:19:37 UTC ---
matthias, could you create a new patch that combines the code changes with the
new test cases being placed into test/layoutengine/standard-testcases? i will
then commit the patch
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52287] [PATCH] fox:orphan/overwrite-content-limit
ignore forced breaks
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52287
Chris Bowditch <bo...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS/Version| |All
--- Comment #2 from Chris Bowditch <bo...@hotmail.com> 2012-01-18 15:23:44 UTC ---
Hi Matthias,
I've taken a look at your test case and I don't think it is a good test case
for fox:widow-content-limit and fox:orphan-content-limit. That's because
there's only 2 list items. To honour the 2em limits both items must be kept
together.
If I alter the test case so that there are several items in column 1 that
naturally flows 1 item onto column 2 then the fox:widow-content-limit extension
is demo'd more readily. The last item from column 1 is then moved to column 2
to honour the widow limit. If I then add the forced break back to the last item
then the last item on column 1 goes back to column 1. This shows that the
forced break does work in some scenarios at least. I have uploaded 2 further
test cases; 1 with the forced break and 1 without.
In conclusion it seems there is a bug with forced breaks not being honoured in
all circumstances and your patch seems to fix it, but I'm not 100% certain if
that's the correct solution. It probably needs to be reviewed by one of the
layout gurus.
Thanks,
Chris
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52287] [PATCH] fox:orphan/overwrite-content-limit
ignore forced breaks
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52287
Glenn Adams <gl...@skynav.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P2 |P3
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52287] [PATCH] fox:orphan/overwrite-content-limit
ignore forced breaks
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52287
--- Comment #5 from Glenn Adams <gl...@skynav.com> 2012-04-07 01:43:02 UTC ---
resetting P2 open bugs to P3 pending further review
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.