[GitHub] [bookkeeper] wenbingshen commented on a diff in pull request #3962: [fix] Fix wrong key for getHttpServerTrustStorePassword

["wenbingshen (via GitHub)" <gi...@apache.org>]

wenbingshen commented on code in PR #3962:
URL: https://github.com/apache/bookkeeper/pull/3962#discussion_r1201573602


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java:
##########
@@ -3698,7 +3700,7 @@ public ServerConfiguration setHttpServerTrustStorePath(String trustStorePath) {
      * @return http server trustStore password
      */
     public String getHttpServerTrustStorePassword() {
-        return getString(HTTP_SERVER_KEY_STORE_PASSWORD);
+        return getString(HTTP_SERVER_TRUST_STORE_PASSWORD);

Review Comment:
   We need to consider that the user configures the wrong trust store password, and then uses the correct key store password to successfully start the bookie. After the upgrade, the wrong trust store password takes effect, causing the bookie upgrade to fail?
   
   This way like PR #3643, does not seem to be fully compatible.
   
   Maybe we need more people to see this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org