You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/13 10:10:00 UTC
[jira] [Commented] (AIRFLOW-6547) Remove unnecessary bunch of codes
on pinot hook
[ https://issues.apache.org/jira/browse/AIRFLOW-6547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014185#comment-17014185 ]
ASF GitHub Bot commented on AIRFLOW-6547:
-----------------------------------------
blcksrx commented on pull request #7150: [AIRFLOW-6547] remove unnecessary bunch of codes on pinot hook
URL: https://github.com/apache/airflow/pull/7150
---
Pinot hook has been implemented by pinotdb and it uses sqlalchmey to interact with pinot. so in this hook the get_records and get_first methods are unnecessary
- [X] Description above provides context of the change
- [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Remove unnecessary bunch of codes on pinot hook
> -----------------------------------------------
>
> Key: AIRFLOW-6547
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6547
> Project: Apache Airflow
> Issue Type: Improvement
> Components: hooks
> Affects Versions: 1.10.7
> Reporter: Sayed Mohammad Hossein Torabi
> Assignee: Sayed Mohammad Hossein Torabi
> Priority: Minor
>
> Pinot hook has been implemented by *pinotdb* and it uses *sqlalchmey* to interact with pinot. so in this hook the *get_records* and *get_first* methods are unnecessary
--
This message was sent by Atlassian Jira
(v8.3.4#803005)