[GitHub] [iceberg] jun-he commented on a change in pull request #922: Add partition spec evolution

[GitBox <gi...@apache.org>]

jun-he commented on a change in pull request #922:
URL: https://github.com/apache/iceberg/pull/922#discussion_r450017686



##########
File path: api/src/test/java/org/apache/iceberg/TestPartitionSpecValidation.java
##########
@@ -38,6 +38,9 @@
   public void testMultipleTimestampPartitions() {
     AssertHelpers.assertThrows("Should not allow year(ts) and year(ts)",
         IllegalArgumentException.class, "Cannot use partition name more than once",
+        () -> PartitionSpec.builderFor(SCHEMA).year("ts", "year").year("another_ts", "year").build());

Review comment:
       I think this change is the side effect if the duplicate partition detection takes precedence over duplicate name detection as discussed in https://github.com/apache/iceberg/pull/922#discussion_r441199360.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org