[GitHub] [incubator-tuweni] atoulme commented on a change in pull request #38: v5 UDP packet handling

[GitBox <gi...@apache.org>]

atoulme commented on a change in pull request #38: v5 UDP packet handling
URL: https://github.com/apache/incubator-tuweni/pull/38#discussion_r335443136
 
 

 ##########
 File path: devp2p/src/main/kotlin/org/apache/tuweni/devp2p/v5/PacketCodec.kt
 ##########
 @@ -0,0 +1,12 @@
+package org.apache.tuweni.devp2p.v5
+
+import org.apache.tuweni.devp2p.v5.packet.UdpMessage
+import java.nio.ByteBuffer
+
+interface PacketCodec {
+
+  fun encode(message: UdpMessage): ByteBuffer
 
 Review comment:
   Use Bytes, not ByteBuffer in interfaces

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org