You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2024/11/07 19:30:39 UTC

[PR] Move all scroll logic to page level [airflow]

bbovenzi opened a new pull request, #43802:
URL: https://github.com/apache/airflow/pull/43802

   Problem: We were not consistent with how scrolling worked. Which led to zIndex and position issues. Scrolling could happen on the webpage but also inside of individual components.
   
   Solution:
   Move scroll logic to the page level. In this case on the DagsList and Dag components
   
   ![code](https://github.com/user-attachments/assets/c9a42168-af13-4176-8343-28c27a7b1248)
   ![card](https://github.com/user-attachments/assets/cd13c728-3218-4920-b71f-7e678f4fa7bb)
   ![table](https://github.com/user-attachments/assets/07904e24-2293-4af3-b77f-0486fba32f07)
   
   
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move all scroll logic to page level [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.

bbovenzi commented on PR #43802:
URL: https://github.com/apache/airflow/pull/43802#issuecomment-2463051982

   cc: @tirkarthi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move all scroll logic to page level [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.

bbovenzi merged PR #43802:
URL: https://github.com/apache/airflow/pull/43802


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org