[GitHub] [incubator-mxnet] liuzh91 edited a comment on issue #16922: Update LoggingHandler to support logging per interval

[GitBox <gi...@apache.org>]

liuzh91 edited a comment on issue #16922: Update LoggingHandler to support logging per interval
URL: https://github.com/apache/incubator-mxnet/pull/16922#issuecomment-560970308
 
 
   > Thanks for the fix. Shall we remove `LOG_PER_BATCH` as it can be replaced by `LOG_PER_INTERVAL`?
   > Since this is in contrib, I think it's fine and less options will be easier for users.
   
   Thanks for the suggestion.
   
   I have thought about the option before. Most parts of logging batch and logging interval are overlapped. But during batch logging, we only logged the training metrics:
   ```
               for metric in self.train_metrics:
                   # only log current training loss & metric after each batch
                   name, value = metric.get()
                   msg += '%s: %.4f, ' % (name, value)
   ``` 
   But during interval logging, I think it is better to log both training and validation metrics. So `LOG_PER_BATCH` is still necessary?
   ```
             for monitor in self.train_metrics + self.val_metrics:
                   name, value = monitor.get()
                   msg += '%s: %.4f, ' % (name, value)
   ```
   Or we can merge `LOG_PER_BATCH` and `LOG_PER_INTERVAL`, then we use `self.log_interval` to check whether using validation metrics or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services