[GitHub] [airflow] ashb commented on a change in pull request #5297: AIRFLOW-2143 - Fix TaskTries graph counts off-by-1

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #5297: AIRFLOW-2143 - Fix TaskTries graph counts off-by-1
URL: https://github.com/apache/airflow/pull/5297#discussion_r292387787
 
 

 ##########
 File path: CONTRIBUTING.md
 ##########
 @@ -158,10 +158,7 @@ There are three ways to setup an Apache Airflow development environment.
   Start a docker container through Compose for development to avoid installing the packages directly on your system. The following will give you a shell inside a container, run all required service containers (MySQL, PostgresSQL, krb5 and so on) and install all the dependencies:
 
   ```bash
-  docker-compose -f scripts/ci/docker-compose.yml run airflow-testing bash
-  # From the container
-  export TOX_ENV=py35-backend_mysql-env_docker
-  /app/scripts/ci/run-ci.sh
+  docker-compose -f scripts/ci/docker-compose.yml run -e TOX_ENV=py35-backend_mysql-env_docker airflow-testing /app/scripts/ci/run-ci.sh
 
 Review comment:
   Please don't make un-related changes to other files.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services