You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Vincent Massol (JIRA)" <de...@geronimo.apache.org> on 2005/12/11 21:16:11 UTC
[jira] Created: (GERONIMO-1333) ejb module should not depend on wsappclient module
ejb module should not depend on wsappclient module
--------------------------------------------------
Key: GERONIMO-1333
URL: http://issues.apache.org/jira/browse/GERONIMO-1333
Project: Geronimo
Type: Improvement
Components: sample apps
Versions: 1.0-M5
Reporter: Vincent Massol
There is dependency on the wsappclient jar in the ejb module. That doesn't look right. Does it mean the wsappclient should be split into 2 modules? I haven't investigated more but it smells like a circular depdency somewhere.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-1333) [Daytrader] ejb module should not
depend on wsappclient module
Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1333?page=all ]
Matt Hogstrom closed GERONIMO-1333:
-----------------------------------
Fix Version: 1.1
(was: 1.2)
Resolution: Fixed
This is being addressed in version 1.2.
> [Daytrader] ejb module should not depend on wsappclient module
> --------------------------------------------------------------
>
> Key: GERONIMO-1333
> URL: http://issues.apache.org/jira/browse/GERONIMO-1333
> Project: Geronimo
> Type: Improvement
> Security: public(Regular issues)
> Components: sample apps
> Versions: 1.0-M5
> Reporter: Vincent Massol
> Assignee: Matt Hogstrom
> Fix For: 1.1
>
> There is dependency on the wsappclient jar in the ejb module. That doesn't look right. Does it mean the wsappclient should be split into 2 modules? I haven't investigated more but it smells like a circular depdency somewhere.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1333) [Daytrader] ejb module should not depend on wsappclient module
Posted by "Vincent Massol (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1333?page=comments#action_12360289 ]
Vincent Massol commented on GERONIMO-1333:
------------------------------------------
I've done some more analysis. The problem comes from TradeWebSoapProxy.java in the ejb module which uses TradeWSServices.java located in the wsapplicent module...
Several things that do not seem right:
* The ejb module should be dedicated to ejbs. If not then it's not correctly named. Maybe a functional name like "business" would be better?
* Currently the ejb module containers the direct code (JDBC/JMS) which has nothing to do with ejbs. It could stay if the module was renamed to something like "business".
* The TradeWSServices.java class should be moved to the "business" module to remove the dependency on wsapplicent
* The ejb module should be producing 2 jars: an EJB jar and an EJB-Client jar
Thanks
> [Daytrader] ejb module should not depend on wsappclient module
> --------------------------------------------------------------
>
> Key: GERONIMO-1333
> URL: http://issues.apache.org/jira/browse/GERONIMO-1333
> Project: Geronimo
> Type: Improvement
> Components: sample apps
> Versions: 1.0-M5
> Reporter: Vincent Massol
> Assignee: Matt Hogstrom
> Fix For: 1.1
>
> There is dependency on the wsappclient jar in the ejb module. That doesn't look right. Does it mean the wsappclient should be split into 2 modules? I haven't investigated more but it smells like a circular depdency somewhere.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1333) [Daytrader] ejb module should not depend on wsappclient module
Posted by "Vincent Massol (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1333?page=all ]
Vincent Massol updated GERONIMO-1333:
-------------------------------------
Summary: [Daytrader] ejb module should not depend on wsappclient module (was: ejb module should not depend on wsappclient module)
> [Daytrader] ejb module should not depend on wsappclient module
> --------------------------------------------------------------
>
> Key: GERONIMO-1333
> URL: http://issues.apache.org/jira/browse/GERONIMO-1333
> Project: Geronimo
> Type: Improvement
> Components: sample apps
> Versions: 1.0-M5
> Reporter: Vincent Massol
>
> There is dependency on the wsappclient jar in the ejb module. That doesn't look right. Does it mean the wsappclient should be split into 2 modules? I haven't investigated more but it smells like a circular depdency somewhere.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DAYTRADER-1) [Daytrader] ejb module should not
depend on wsappclient module
Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/DAYTRADER-1?page=comments#action_12437972 ]
Matt Hogstrom commented on DAYTRADER-1:
---------------------------------------
I did not expose it Chris because it required some additional scrubbing and wasn't my primary concern. I think the standalone app could easily disappear. I['m not sure about the SoapProxy as there is no good way to test WS that I'm aware of. Personally though, I'm not big on WS anyway. Perhaps DJencks has some opinion here.
> [Daytrader] ejb module should not depend on wsappclient module
> --------------------------------------------------------------
>
> Key: DAYTRADER-1
> URL: http://issues.apache.org/jira/browse/DAYTRADER-1
> Project: DayTrader
> Issue Type: Bug
> Components: EJB Tier
> Reporter: Vincent Massol
> Assigned To: Matt Hogstrom
>
> There is dependency on the wsappclient jar in the ejb module. That doesn't look right. Does it mean the wsappclient should be split into 2 modules? I haven't investigated more but it smells like a circular depdency somewhere.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (GERONIMO-1333) [Daytrader] ejb module should not
depend on wsappclient module
Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1333?page=all ]
Matt Hogstrom reopened GERONIMO-1333:
-------------------------------------
Oops...meant to comment and update...my bad.
> [Daytrader] ejb module should not depend on wsappclient module
> --------------------------------------------------------------
>
> Key: GERONIMO-1333
> URL: http://issues.apache.org/jira/browse/GERONIMO-1333
> Project: Geronimo
> Type: Improvement
> Security: public(Regular issues)
> Components: sample apps
> Versions: 1.0-M5
> Reporter: Vincent Massol
> Assignee: Matt Hogstrom
> Fix For: 1.1
>
> There is dependency on the wsappclient jar in the ejb module. That doesn't look right. Does it mean the wsappclient should be split into 2 modules? I haven't investigated more but it smells like a circular depdency somewhere.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DAYTRADER-1) [Daytrader] ejb module should not
depend on wsappclient module
Posted by "Christopher James Blythe (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/DAYTRADER-1?page=comments#action_12437912 ]
Christopher James Blythe commented on DAYTRADER-1:
--------------------------------------------------
Just out of curiousity, is anyone using the web services app client? Was wondering if we could simply remove it along with the TradeWebSoapProxy?
These two are actually independent. The web services app client was created to test web service invocations of the Daytrader web services from a standalone J2EE client. The TradeWebSoapProxy, was added as a means of testing web services and driving the transactions via a browser and the basic servlets/JSPs. Consequently, a request to the action servlet would coordinate with the WebSoapProxy to invoke the target web service.
Given the interest in AJAX, I think the AJAX-based interface that is currently in POC would remove the need for these items.
> [Daytrader] ejb module should not depend on wsappclient module
> --------------------------------------------------------------
>
> Key: DAYTRADER-1
> URL: http://issues.apache.org/jira/browse/DAYTRADER-1
> Project: DayTrader
> Issue Type: Bug
> Components: EJB Tier
> Reporter: Vincent Massol
> Assigned To: Matt Hogstrom
>
> There is dependency on the wsappclient jar in the ejb module. That doesn't look right. Does it mean the wsappclient should be split into 2 modules? I haven't investigated more but it smells like a circular depdency somewhere.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (DAYTRADER-1) [Daytrader] ejb module should not
depend on wsappclient module
Posted by "Anonymous (JIRA)" <de...@geronimo.apache.org>.
[ https://issues.apache.org/jira/browse/DAYTRADER-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Affects Version/s: (was: 1.2)
1.1.1
> [Daytrader] ejb module should not depend on wsappclient module
> --------------------------------------------------------------
>
> Key: DAYTRADER-1
> URL: https://issues.apache.org/jira/browse/DAYTRADER-1
> Project: DayTrader
> Issue Type: Bug
> Components: EJB Tier
> Affects Versions: 1.1.1
> Reporter: Vincent Massol
> Assigned To: Matt Hogstrom
>
> There is dependency on the wsappclient jar in the ejb module. That doesn't look right. Does it mean the wsappclient should be split into 2 modules? I haven't investigated more but it smells like a circular depdency somewhere.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAYTRADER-1) [Daytrader] ejb module should not
depend on wsappclient module
Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/DAYTRADER-1?page=comments#action_12437978 ]
David Jencks commented on DAYTRADER-1:
--------------------------------------
I recently got the ws app client to work against g. trunk and the jee5-jetty6 integration. I would strongly prefer that we leave it in place since it works and we have really few examples especially non-trivial examples of anything.
If there's a code dependency from the ejb module to the wsappclient module that is definitely something we need to fix. Vincents original comments look reasonable to me, but I'm not that familiar with daytrader.
> [Daytrader] ejb module should not depend on wsappclient module
> --------------------------------------------------------------
>
> Key: DAYTRADER-1
> URL: http://issues.apache.org/jira/browse/DAYTRADER-1
> Project: DayTrader
> Issue Type: Bug
> Components: EJB Tier
> Reporter: Vincent Massol
> Assigned To: Matt Hogstrom
>
> There is dependency on the wsappclient jar in the ejb module. That doesn't look right. Does it mean the wsappclient should be split into 2 modules? I haven't investigated more but it smells like a circular depdency somewhere.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1333) [Daytrader] ejb module should not depend on wsappclient module
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1333?page=all ]
Aaron Mulder updated GERONIMO-1333:
-----------------------------------
Fix Version: 1.1
Assign To: Matt Hogstrom
> [Daytrader] ejb module should not depend on wsappclient module
> --------------------------------------------------------------
>
> Key: GERONIMO-1333
> URL: http://issues.apache.org/jira/browse/GERONIMO-1333
> Project: Geronimo
> Type: Improvement
> Components: sample apps
> Versions: 1.0-M5
> Reporter: Vincent Massol
> Assignee: Matt Hogstrom
> Fix For: 1.1
>
> There is dependency on the wsappclient jar in the ejb module. That doesn't look right. Does it mean the wsappclient should be split into 2 modules? I haven't investigated more but it smells like a circular depdency somewhere.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira