You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by cz...@apache.org on 2008/01/11 17:06:23 UTC
svn commit: r611217 - in
/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl:
AbstractComponentManager.java ComponentFactoryImpl.java
DependencyManager.java ReferenceMetadata.java XmlHandler.java
parser/KXml2SAXParser.java
Author: cziegeler
Date: Fri Jan 11 08:06:20 2008
New Revision: 611217
URL: http://svn.apache.org/viewvc?rev=611217&view=rev
Log:
Correct javadocs and clean up code a little bit.
Modified:
felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/AbstractComponentManager.java
felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ComponentFactoryImpl.java
felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/DependencyManager.java
felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ReferenceMetadata.java
felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/XmlHandler.java
felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/parser/KXml2SAXParser.java
Modified: felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/AbstractComponentManager.java
URL: http://svn.apache.org/viewvc/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/AbstractComponentManager.java?rev=611217&r1=611216&r2=611217&view=diff
==============================================================================
--- felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/AbstractComponentManager.java (original)
+++ felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/AbstractComponentManager.java Fri Jan 11 08:06:20 2008
@@ -19,20 +19,11 @@
package org.apache.felix.scr.impl;
-import java.lang.reflect.InvocationTargetException;
-import java.lang.reflect.Method;
-import java.lang.reflect.Modifier;
-import java.util.ArrayList;
-import java.util.Dictionary;
-import java.util.Enumeration;
-import java.util.Hashtable;
-import java.util.Iterator;
-import java.util.List;
+import java.lang.reflect.*;
+import java.util.*;
import org.apache.felix.scr.Reference;
-import org.osgi.framework.Bundle;
-import org.osgi.framework.ServiceReference;
-import org.osgi.framework.ServiceRegistration;
+import org.osgi.framework.*;
import org.osgi.service.component.ComponentInstance;
import org.osgi.service.log.LogService;
@@ -288,7 +279,6 @@
/**
* Enable this component
*
- * @return true if enabling was successful
*/
private void enableInternal()
{
Modified: felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ComponentFactoryImpl.java
URL: http://svn.apache.org/viewvc/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ComponentFactoryImpl.java?rev=611217&r1=611216&r2=611217&view=diff
==============================================================================
--- felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ComponentFactoryImpl.java (original)
+++ felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ComponentFactoryImpl.java Fri Jan 11 08:06:20 2008
@@ -19,19 +19,12 @@
package org.apache.felix.scr.impl;
-import java.util.Dictionary;
-import java.util.HashMap;
-import java.util.Hashtable;
-import java.util.IdentityHashMap;
-import java.util.Map;
+import java.util.*;
-import org.apache.felix.scr.Reference;
import org.osgi.framework.Constants;
import org.osgi.framework.ServiceRegistration;
import org.osgi.service.cm.ManagedServiceFactory;
-import org.osgi.service.component.ComponentConstants;
-import org.osgi.service.component.ComponentFactory;
-import org.osgi.service.component.ComponentInstance;
+import org.osgi.service.component.*;
import org.osgi.service.log.LogService;
Modified: felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/DependencyManager.java
URL: http://svn.apache.org/viewvc/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/DependencyManager.java?rev=611217&r1=611216&r2=611217&view=diff
==============================================================================
--- felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/DependencyManager.java (original)
+++ felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/DependencyManager.java Fri Jan 11 08:06:20 2008
@@ -19,24 +19,11 @@
package org.apache.felix.scr.impl;
-import java.lang.reflect.InvocationTargetException;
-import java.lang.reflect.Method;
-import java.lang.reflect.Modifier;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.Dictionary;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import java.lang.reflect.*;
+import java.util.*;
import org.apache.felix.scr.Reference;
-import org.osgi.framework.BundleContext;
-import org.osgi.framework.Constants;
-import org.osgi.framework.Filter;
-import org.osgi.framework.InvalidSyntaxException;
-import org.osgi.framework.ServiceEvent;
-import org.osgi.framework.ServiceListener;
-import org.osgi.framework.ServiceReference;
+import org.osgi.framework.*;
import org.osgi.service.log.LogService;
@@ -910,7 +897,7 @@
return true;
}
}
- else if ( implementationObject == null && m_componentManager.getComponentMetadata().isImmediate() == false )
+ else if ( m_componentManager.getComponentMetadata().isImmediate() == false )
{
return true;
}
@@ -1016,7 +1003,7 @@
}
}
- else if ( implementationObject == null && m_componentManager.getComponentMetadata().isImmediate() == false )
+ else if ( m_componentManager.getComponentMetadata().isImmediate() == false )
{
return true;
}
Modified: felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ReferenceMetadata.java
URL: http://svn.apache.org/viewvc/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ReferenceMetadata.java?rev=611217&r1=611216&r2=611217&view=diff
==============================================================================
--- felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ReferenceMetadata.java (original)
+++ felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ReferenceMetadata.java Fri Jan 11 08:06:20 2008
@@ -184,7 +184,7 @@
/**
* Setter for the unbind method attribute
*
- * @param bind
+ * @param unbind
*/
public void setUnbind( String unbind )
{
Modified: felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/XmlHandler.java
URL: http://svn.apache.org/viewvc/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/XmlHandler.java?rev=611217&r1=611216&r2=611217&view=diff
==============================================================================
--- felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/XmlHandler.java (original)
+++ felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/XmlHandler.java Fri Jan 11 08:06:20 2008
@@ -22,11 +22,7 @@
import java.io.IOException;
import java.io.InputStream;
import java.net.URL;
-import java.util.ArrayList;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Map;
-import java.util.Properties;
+import java.util.*;
import org.apache.felix.scr.impl.parser.KXml2SAXHandler;
import org.apache.felix.scr.impl.parser.ParseException;
@@ -231,7 +227,6 @@
*
* @param uri
* @param localName
- * @exception ParseException
*/
public void endElement( String uri, String localName )
{
Modified: felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/parser/KXml2SAXParser.java
URL: http://svn.apache.org/viewvc/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/parser/KXml2SAXParser.java?rev=611217&r1=611216&r2=611217&view=diff
==============================================================================
--- felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/parser/KXml2SAXParser.java (original)
+++ felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/parser/KXml2SAXParser.java Fri Jan 11 08:06:20 2008
@@ -53,7 +53,7 @@
* Parser from the reader provided in the constructor, and call
* the startElement and endElement in a KxmlHandler
*
- * @param reader The reader
+ * @param handler The handler
* @exception Exception thrown by the superclass
*/
public void parseXML( KXml2SAXHandler handler ) throws Exception